public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Mr. Berkley Shands" <berkley@dssimail.com>
To: linux-kernel@vger.kernel.org
Subject: sendfile64() on x86_64 breaks at 2gb (MAX_NON_LFS limit)
Date: Thu, 23 Sep 2004 12:09:29 -0500	[thread overview]
Message-ID: <41530349.2050003@dssimail.com> (raw)

for the opteron, the value of MAX_NON_LFS (include/linux/fs.h) is fixed 
at (1UL<<31 -1).
Since ALL 64 bit boxes force O_LARGEFILE on, shouldn't this value be 
(1UL<<63 -1) so that
sendfile64() will proceed beyond the 2gb limit?
under 2.6.6, sendfile64() has no __NR_sendfile64 entry in asm*/unistd.h 
(same for 2.6.9-rc2)
so the syscall sendfile64() maps to sendfile(), which has MAX_NON_LFS 
hard coded in fs/read_write.c
as its limit, rather than 0ULL as in sendfile64().

So the fix is to make the correct entry for sendfile64 in unistd.h (note 
that this hoses /usr/include/.../syscalls.h :-)
and update fs.h as folows:


--- fs.h.old    2004-09-23 11:44:33.469481466 -0500
+++ fs.h        2004-09-23 11:29:56.823712018 -0500
@@ -589,7 +589,11 @@
 /* Release a private file and free its security structure. */
 extern void close_private_file(struct file *file);
 
+#if BITS_PER_LONG==32
 #define        MAX_NON_LFS     ((1UL<<31) - 1)
+#else
+#define        MAX_NON_LFS     ((1UL<<63) - 1)
+#endif
 
 /* Page cache limit. The filesystems should put that into their s_maxbytes
    limits, otherwise bad things can happen in VM. */


Please consider making these updates in the next rev of the kernel sources.

Berkley Shands


             reply	other threads:[~2004-09-23 17:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-23 17:09 Mr. Berkley Shands [this message]
2004-09-23 17:28 ` sendfile64() on x86_64 breaks at 2gb (MAX_NON_LFS limit) Jakub Jelinek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41530349.2050003@dssimail.com \
    --to=berkley@dssimail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox