From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Reuben Farrelly <reuben-lkml@reub.net>
Cc: linux-kernel@vger.kernel.org, Jens Axboe <axboe@suse.de>,
Neil Brown <neilb@cse.unsw.edu.au>
Subject: Re: Stack traces in 2.6.9-rc2-mm4
Date: Mon, 27 Sep 2004 18:23:25 +1000 [thread overview]
Message-ID: <4157CDFD.5030001@yahoo.com.au> (raw)
In-Reply-To: <6.1.2.0.2.20040927184123.019b48b8@tornado.reub.net>
Reuben Farrelly wrote:
> Since upgrading from -mm3 to -mm4, I'm now getting messages like this
> logged every second or so:
>
> Sep 27 18:28:06 tornado kernel: using smp_processor_id() in preemptible
>
snip
>
> Is there a fix to shut this all up or a suggested patch to revert?
>
> Box is a P4 Intel 2.8Ghz single processor, SMP/HT with PREEMPT on..
>
Looks like disk_stat_add in the sw-raid code. The proper fix is probably
to disable preempt around those regions - but just doing it the dumb
way (ie. in the driver code) looks like an unfortunate layering violation.
Maybe something like disk_stat_update_start / disk_stat_update_end that
gives you the per-cpu stat pointer as a "token" to be used by
disk_stat_inc/add/etc. Anyone?
Named slightly differently, so you keep backward compatibility, of course.
next prev parent reply other threads:[~2004-09-27 9:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-27 8:01 Stack traces in 2.6.9-rc2-mm4 Reuben Farrelly
2004-09-27 8:23 ` Nick Piggin [this message]
2004-09-27 8:57 ` Ingo Molnar
2004-09-27 9:14 ` Reuben Farrelly
2004-09-27 23:12 ` J.A. Magallon
2004-09-28 7:21 ` Ingo Molnar
2004-09-28 7:49 ` Nick Piggin
2004-09-28 10:24 ` Ingo Molnar
2004-09-28 10:48 ` Nick Piggin
2004-09-30 21:58 ` J.A. Magallon
2004-09-30 22:56 ` Ingo Molnar
2004-09-30 23:16 ` J.A. Magallon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4157CDFD.5030001@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
--cc=reuben-lkml@reub.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox