From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752488AbcECFrf (ORCPT ); Tue, 3 May 2016 01:47:35 -0400 Received: from ipmail06.adl2.internode.on.net ([150.101.137.129]:51155 "EHLO ipmail06.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750756AbcECFre (ORCPT ); Tue, 3 May 2016 01:47:34 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2AwDQDwOihXcwpSY3pehQiFILJdhBOGEAKCDAEBAQEBARMBFzMvhEIBAQQ6PxALDgoJFRAPAUcGE4gpuwMBAQEHAgEdim2KFgWYFI5+jixFjmyCZxsWgUcqMIg8AQEB From: Alistair Popple To: Alexey Kardashevskiy Cc: linuxppc-dev@lists.ozlabs.org, Alex Williamson , Benjamin Herrenschmidt , Dan Carpenter , Daniel Axtens , David Gibson , Gavin Shan , Russell Currey , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH kernel v4 08/11] powerpc/powernv/ioda2: Export debug helper pe_level_printk() Date: Tue, 03 May 2016 15:46:33 +1000 Message-ID: <4159435.eIvAFi7xxQ@new-mexico> User-Agent: KMail/4.14.1 (Linux/4.2.0-0.bpo.1-amd64; KDE/4.14.2; x86_64; ; ) In-Reply-To: <1461920124-21719-9-git-send-email-aik@ozlabs.ru> References: <1461920124-21719-1-git-send-email-aik@ozlabs.ru> <1461920124-21719-9-git-send-email-aik@ozlabs.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There's one call to pr_warn() in pnv_npu_disable_bypass() that could arguably be converted to pe_warn(), but we can clean that up later as the patch looks fine and I'm assuming subsequent patches make use of these. Reviewed-By: Alistair Popple On Fri, 29 Apr 2016 18:55:21 Alexey Kardashevskiy wrote: > This exports debugging helper pe_level_printk() and corresponding macroses > so they can be used in npu-dma.c. > > Signed-off-by: Alexey Kardashevskiy > --- > arch/powerpc/platforms/powernv/pci-ioda.c | 9 +-------- > arch/powerpc/platforms/powernv/pci.h | 9 +++++++++ > 2 files changed, 10 insertions(+), 8 deletions(-) > > diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c > index 272521e..db7695f 100644 > --- a/arch/powerpc/platforms/powernv/pci-ioda.c > +++ b/arch/powerpc/platforms/powernv/pci-ioda.c > @@ -56,7 +56,7 @@ > > static void pnv_pci_ioda2_table_free_pages(struct iommu_table *tbl); > > -static void pe_level_printk(const struct pnv_ioda_pe *pe, const char *level, > +void pe_level_printk(const struct pnv_ioda_pe *pe, const char *level, > const char *fmt, ...) > { > struct va_format vaf; > @@ -87,13 +87,6 @@ static void pe_level_printk(const struct pnv_ioda_pe *pe, const char *level, > va_end(args); > } > > -#define pe_err(pe, fmt, ...) \ > - pe_level_printk(pe, KERN_ERR, fmt, ##__VA_ARGS__) > -#define pe_warn(pe, fmt, ...) \ > - pe_level_printk(pe, KERN_WARNING, fmt, ##__VA_ARGS__) > -#define pe_info(pe, fmt, ...) \ > - pe_level_printk(pe, KERN_INFO, fmt, ##__VA_ARGS__) > - > static bool pnv_iommu_bypass_disabled __read_mostly; > > static int __init iommu_setup(char *str) > diff --git a/arch/powerpc/platforms/powernv/pci.h b/arch/powerpc/platforms/powernv/pci.h > index d574a9d..485e5b1 100644 > --- a/arch/powerpc/platforms/powernv/pci.h > +++ b/arch/powerpc/platforms/powernv/pci.h > @@ -236,6 +236,15 @@ extern void pnv_pci_dma_bus_setup(struct pci_bus *bus); > extern int pnv_setup_msi_irqs(struct pci_dev *pdev, int nvec, int type); > extern void pnv_teardown_msi_irqs(struct pci_dev *pdev); > > +extern void pe_level_printk(const struct pnv_ioda_pe *pe, const char *level, > + const char *fmt, ...); > +#define pe_err(pe, fmt, ...) \ > + pe_level_printk(pe, KERN_ERR, fmt, ##__VA_ARGS__) > +#define pe_warn(pe, fmt, ...) \ > + pe_level_printk(pe, KERN_WARNING, fmt, ##__VA_ARGS__) > +#define pe_info(pe, fmt, ...) \ > + pe_level_printk(pe, KERN_INFO, fmt, ##__VA_ARGS__) > + > /* Nvlink functions */ > extern void pnv_npu_init_dma_pe(struct pnv_ioda_pe *npe); > extern void pnv_npu_setup_dma_pe(struct pnv_ioda_pe *npe); >