Re: [Patch] Fix oops on rmmod usb-storage

James Bottomley
2004-09-29T14:56:58Z

On Wed, 2004-09-29 at 09:17, Alan Cox wrote:
> On Mer, 2004-09-29 at 14:56, James Bottomley wrote:
> > The key to the solution of this problem is to know what USB is trying to
> > do with the dead device. SCSI is trying to be polite and explicitly
> > kill the outstanding commands before it removes the HBA. Presumably USB
> > is returning something that says this can't be done so the EH gets all
> > the way up to offlining.
>
> Its nothing to do with USB, rmmod with eh running crashes all the other
> SCSI drivers I've tested too. After the state transition fails you get
> kobject related errors and a crash.

There is no crash in the log ... there was only a state transition
complaint.

I think the solution is in the eh and its simply not to try to ready the
device on SDEV_CANCEL (no point readying a device you're being asked to
kill).

James