Re: 2.6.9-rc3 software suspend (pmdisk) stopped working

Re: 2.6.9-rc3 software suspend (pmdisk) stopped working

[Mitch]

Kevin Fenzi <kevin-linux-kernel () scrye ! com> wrote:
 >
 > What do you get from:
 >
 > cat /sys/power/disk
 > ?

Do you mean /sys/power/state ? /sys/power/disk is for powering off the
disk ? Anyhow here are both of them

	~% cat /sys/power/disk
	shutdown
	~% cat /sys/power/state
	standby mem disk

Remember this worked fine in -rc2.

 > If it says "platform" you might try:
 >
 > echo "shutdown" > /sys/power/disk
 >
 > I wonder how many of Pavel's speed improvment patches went in with the
 > pmdisk/swsusp merge in rc3? I guess I can try it and see. :)

The speed improvement that made it stop working surely went in ;-)

Cheers
Mitch

Re: 2.6.9-rc3 software suspend (pmdisk) stopped working

[Kevin Fenzi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

>>>>> "Mitch" == Mitch  <Mitch@0Bits.COM> writes:

Mitch> Kevin Fenzi <kevin-linux-kernel () scrye ! com> wrote:
>> What do you get from:
>> 
>> cat /sys/power/disk ?

Mitch> Do you mean /sys/power/state ? /sys/power/disk is for powering
Mitch> off the disk ? Anyhow here are both of them

/sys/power/disk is for deciding how to do suspend to disk. 
shutdown = do it with the in kernel code
platform = do it with the BIOS code

Mitch> 	~% cat /sys/power/disk shutdown ~% cat /sys/power/state
Mitch> standby mem disk

Mitch> Remember this worked fine in -rc2.

Yes, but in rc3 the merge between pmdisk and swsusp1 happened. 
It basically has totally changed between rc2 and rc3. 

So, looks like that setting is right. 

So if you wait until it's done writing out pages and hard power it
off, does it resume? 

Does it work if you boot with: 
acpi=off

>> If it says "platform" you might try:
>> 
>> echo "shutdown" > /sys/power/disk
>> 
>> I wonder how many of Pavel's speed improvment patches went in with
>> the pmdisk/swsusp merge in rc3? I guess I can try it and see. :)

Mitch> The speed improvement that made it stop working surely went in
Mitch> ;-)

Well, thats not one we want. ;) 

kevin
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Processed by Mailcrypt 3.5.8 <http://mailcrypt.sourceforge.net/>

iD8DBQFBXDvF3imCezTjY0ERAggZAJ45K56uCqeVpuq73m6T2KZsupiDqQCfbArn
vXqp6Gr+G63iTzxhNY7CzTo=
=S6ow
-----END PGP SIGNATURE-----

Re: 2.6.9-rc3 software suspend (pmdisk) stopped working

[Mitch]

Well it appears that Jesse and Kevin are right and irrespective of the 
setting of /sys/power/disk, i can get the machine to suspend by first 
writing 'platform' into the 'disk' file. And it resumes fine ok. Seems 
to be a false alarm on my part Pavel, although the doc's need updating 
and /sys/power/disk made to show the correct supported suspension methods ?

Thanks for the tips guys (i didn't need the c code Jesse)
M

-------- Original Message --------
Subject: Re: 2.6.9-rc3 software suspend (pmdisk) stopped working
Date: Sat, 02 Oct 2004 16:32:33 -0400
From: Jesse <ottdot@magma.ca>
To: Mitch <Mitch@HasBox.COM>
CC: pavel@suse.cz, linux-kernel@vger.kernel.org
References: <415FFE77.7090908@HasBox.COM>

Mitch wrote:
> Hi Jesse,
> 
> as shown below, that is  not one of the options presented to me in my 
> 'disk' file
> 
> % cat /sys/power/disk
> shutdown
> 

My machine shows the same thing. Only shutdown in /sys/power/disk

Grab the code from Documentation/power/swsusp.txt (starts at line 151)

I compiled it to an executable called swsusp and I then run 'swsusp' to
start the suspend process.

2.6.9-rc3 was my first attempt at suspend, and it worked as designed on
the first try.

Jesse

Re: 2.6.9-rc3 software suspend (pmdisk) stopped working

[Pavel Machek]

Hi!

> Well it appears that Jesse and Kevin are right and irrespective of 
> the setting of /sys/power/disk, i can get the machine to suspend by 
> first writing 'platform' into the 'disk' file. And it resumes fine 
> ok. Seems to be a false alarm on my part Pavel, although the doc's 
> need updating and /sys/power/disk made to show the correct supported 
> suspension methods ?

It seemed to me that some driver is blocking suspend (USB?). I do not
know what is wrong with that disk file, it looks like a bug.
-- 
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms         

Re: 2.6.9-rc3 software suspend (pmdisk) stopped working

[Stefan Seyfried]

Hello,

Pavel Machek wrote:
> Hi!

> I do not
> know what is wrong with that disk file, it looks like a bug.

reading /sys/power/disk gives you the _active_ state, not the available 
states.

HTH,
        Stefan

Re: 2.6.9-rc3 software suspend (pmdisk) stopped working

[Mitch]

Hi Jesse,

as shown below, that is  not one of the options presented to me in my 
'disk' file

% cat /sys/power/disk
shutdown

My machine can only use the shutdown keyword - which worked in -rc3.

Mitch

-------- Original Message --------
Subject: Re: 2.6.9-rc3 software suspend (pmdisk) stopped working
Date: Sun, 03 Oct 2004 09:12:52 -0400
From: Jesse <ottdot@magma.ca>
To: Mitch <Mitch@0Bits.COM>
CC: pavel@suse.cz, linux-kernel@vger.kernel.org
References: <415FFA57.8040601@0Bits.COM>

Mitch wrote:
> Hi,
> 
> Ok, here is the kernel messages attached. Nothing of real value in it as 
> far as i can see (even with PM_DEBUG on), but you may spot something. 
> Basically the suspend process appears to start but the machine is never 
> powered off and the resume kernel routines are run immediately bringing 
> the kernel/system back to it's resumed state. The *same* kernel config 
> works on -rc2. If i hard power off the machine then i have to fsck my 
> disks on bootup (as expected) and the suspended image is not loaded.
> Clearly the latest patches have broken something but what ? Can anyone 
> else without ACPI suspend on -rc3 ?
> 

It's working for me on my Thinkpad 600x (ACPI is not compiled in) Used
'reboot' command from Documentation.power/swsusp.txt

Jesse

Re: 2.6.9-rc3 software suspend (pmdisk) stopped working

[Jesse]

Mitch wrote:
> Hi Jesse,
> 
> as shown below, that is  not one of the options presented to me in my 
> 'disk' file
> 
> % cat /sys/power/disk
> shutdown
> 

My machine shows the same thing. Only shutdown in /sys/power/disk

Grab the code from Documentation/power/swsusp.txt (starts at line 151)

I compiled it to an executable called swsusp and I then run 'swsusp' to 
start the suspend process.

2.6.9-rc3 was my first attempt at suspend, and it worked as designed on 
the first try.

Jesse

Re: 2.6.9-rc3 software suspend (pmdisk) stopped working

[Mitch]

[-- Attachment #1: Type: text/plain, Size: 2082 bytes --]

Hi,

Ok, here is the kernel messages attached. Nothing of real value in it as 
far as i can see (even with PM_DEBUG on), but you may spot something. 
Basically the suspend process appears to start but the machine is never 
powered off and the resume kernel routines are run immediately bringing 
the kernel/system back to it's resumed state. The *same* kernel config 
works on -rc2. If i hard power off the machine then i have to fsck my 
disks on bootup (as expected) and the suspended image is not loaded.
Clearly the latest patches have broken something but what ? Can anyone 
else without ACPI suspend on -rc3 ?


 > Check your .config to see if it is enabled, and make sure you have
 > resume= on command line. If it still fails, mail me dmesg of failed
 > attempt.

As i keep mentioning, i have a problem with *shutting down* not 
resuming. I'm assuming if a good memory image is written and machine 
powered off correctly i will be able to resume correctly (with the 
recent hihgmem fix). We should be looking at why APM BIOS shutdown 
routine is not working correctly.

My kernel values

% grep -i CONFIG_PM .config
CONFIG_PM=y
CONFIG_PM_DEBUG=y
CONFIG_PM_STD_PARTITION="/dev/hda2"

/sys/power% cat disk
shutdown
/sys/power% cat state
standby mem disk

To suspend i do

echo -n disk >/sys/power/state

Thanks for any more suggestions
M
-------- Original Message --------
Subject: Re: 2.6.9-rc3 software suspend (pmdisk) stopped working
Date: Sat, 2 Oct 2004 16:22:05 +0200
From: Pavel Machek <pavel@suse.cz>
To: Mitch  <Mitch@0Bits.COM>
CC: linux-kernel@vger.kernel.org

Hi!

 > I don't understand. The highmem issue was when resuming, not when
 > suspending ? My laptop doesn't suspend with -rc3. Please elaborate ?
 > What config do i change ? Remember i don't have ACPI, so unless pmdisk
 > supports APM BIOS poweroff, then -rc3 is useless to me.

There's no pmdisk in -rc3.

swsusp in -rc3 should support apm.

Check your .config to see if it is enabled, and make sure you have
resume= on command line. If it still fails, mail me dmesg of failed
attempt.

								Pavel

[-- Attachment #2: kernellog.txt --]
[-- Type: text/plain, Size: 1421 bytes --]

Oct  3 14:39:19 client kernel: Stopping tasks: =============================================|
Oct  3 14:39:19 client kernel: Freeing memory: .................................................|
Oct  3 14:39:19 client kernel: uhci_hcd 0000:00:1d.2: suspend_hc
Oct  3 14:39:19 client kernel: uhci_hcd 0000:00:1d.1: suspend_hc
Oct  3 14:39:19 client kernel: uhci_hcd 0000:00:1d.0: suspend_hc
Oct  3 14:39:19 client kernel: PM: Attempting to suspend to disk.
Oct  3 14:39:19 client kernel: PM: snapshotting memory.
Oct  3 14:39:19 client kernel: PCI: Setting latency timer of device 0000:00:1d.0 to 64
Oct  3 14:39:19 client kernel: PCI: Setting latency timer of device 0000:00:1d.0 to 64
Oct  3 14:39:19 client kernel: PCI: Setting latency timer of device 0000:00:1d.1 to 64
Oct  3 14:39:19 client kernel: PCI: Setting latency timer of device 0000:00:1d.1 to 64
Oct  3 14:39:19 client kernel: PCI: Setting latency timer of device 0000:00:1d.2 to 64
Oct  3 14:39:19 client kernel: PCI: Setting latency timer of device 0000:00:1d.2 to 64
Oct  3 14:39:21 client kernel: PCI: Found IRQ 11 for device 0000:00:1f.1
Oct  3 14:39:21 client kernel: PCI: Sharing IRQ 11 with 0000:00:1d.2
Oct  3 14:39:21 client kernel: uhci_hcd 0000:00:1d.1: wakeup_hc
Oct  3 14:39:21 client kernel: uhci_hcd 0000:00:1d.2: wakeup_hc
Oct  3 14:39:21 client kernel: uhci_hcd 0000:00:1d.0: wakeup_hc
Oct  3 14:39:21 client kernel: Restarting tasks... done

Re: 2.6.9-rc3 software suspend (pmdisk) stopped working

[Jesse]

Mitch wrote:
> Hi,
> 
> Ok, here is the kernel messages attached. Nothing of real value in it as 
> far as i can see (even with PM_DEBUG on), but you may spot something. 
> Basically the suspend process appears to start but the machine is never 
> powered off and the resume kernel routines are run immediately bringing 
> the kernel/system back to it's resumed state. The *same* kernel config 
> works on -rc2. If i hard power off the machine then i have to fsck my 
> disks on bootup (as expected) and the suspended image is not loaded.
> Clearly the latest patches have broken something but what ? Can anyone 
> else without ACPI suspend on -rc3 ?
> 

It's working for me on my Thinkpad 600x (ACPI is not compiled in) Used 
'reboot' command from Documentation.power/swsusp.txt

Jesse

Re: 2.6.9-rc3 software suspend (pmdisk) stopped working

[Mitch]

I don't understand. The highmem issue was when resuming, not when
suspending ? My laptop doesn't suspend with -rc3. Please elaborate ?
What config do i change ? Remember i don't have ACPI, so unless pmdisk
supports APM BIOS poweroff, then -rc3 is useless to me.

Thanks
M
-------- Original Message --------
Subject: Re: 2.6.9-rc3 software suspend (pmdisk) stopped working
Date: Fri, 1 Oct 2004 15:40:05 +0200
From: Pavel Machek <pavel@suse.cz>
To: Mitch DSouza <Mitch@0Bits.COM>
CC: linux-kernel@vger.kernel.org
References: <415D311E.2050006@0Bits.COM>

Hi!

> I thought i was going barmy. I've reverted back to -rc2 which
> pmdisk works flawlessly on my laptop.

Actually problem turned out to be in highmem. Unless you
are using highmem, -rc3 should work. You'll need to change config if
switching from pmdisk to swsusp...

				Pavel

Re: 2.6.9-rc3 software suspend (pmdisk) stopped working

[Pavel Machek]

Hi!

> I don't understand. The highmem issue was when resuming, not when
> suspending ? My laptop doesn't suspend with -rc3. Please elaborate ?
> What config do i change ? Remember i don't have ACPI, so unless pmdisk
> supports APM BIOS poweroff, then -rc3 is useless to me.

There's no pmdisk in -rc3.

swsusp in -rc3 should support apm.

Check your .config to see if it is enabled, and make sure you have
resume= on command line. If it still fails, mail me dmesg of failed
attempt.

								Pavel
-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!

Re: 2.6.9-rc3 software suspend (pmdisk) stopped working

[Mitch DSouza]

Thanks Pavel,

I thought i was going barmy. I've reverted back to -rc2 which
pmdisk works flawlessly on my laptop.

Thanks
Mitch

-------- Original Message --------
Subject: Re: 2.6.9-rc3 software suspend (pmdisk) stopped working
Date: Fri, 1 Oct 2004 12:23:51 +0200
From: Pavel Machek <pavel@ucw.cz>
To: Mitch <Mitch@0Bits.COM>
CC: linux-kernel@vger.kernel.org
References: <415C2633.3050802@0Bits.COM>

Hi!

> Anyone noticed that pmdisk software suspend stopped working in -rc3 ?
> In -rc2 it worked just fine. My script was
> 
>  chvt 1
>  echo -n shutdown >/sys/power/disk
>  echo -n disk >/sys/power/state
>  chvt 7
> 
> In -rc3 it appears to write pages out to disk, but never shuts down the
> machine. Is there something else i need to do or am missing ?

You are not missing anything, it is somehow broken. I'll try to find
out what went wrong and fix it. In the meantime, look at -mm series,
it works there.
								Pavel

Re: 2.6.9-rc3 software suspend (pmdisk) stopped working

[Pavel Machek]

Hi!

> I thought i was going barmy. I've reverted back to -rc2 which
> pmdisk works flawlessly on my laptop.

Actually problem turned out to be in highmem. Unless you
are using highmem, -rc3 should work. You'll need to change config if
switching from pmdisk to swsusp...

				Pavel
-- 
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms         

Re: 2.6.9-rc3 software suspend (pmdisk) stopped working

[Mitch]

Kevin Fenzi <kevin-linux-kernel () scrye ! com> wrote:
 >
 > /sys/power/disk is for deciding how to do suspend to disk.
 > shutdown = do it with the in kernel code
 > platform = do it with the BIOS code
 >
 > Mitch>  ~% cat /sys/power/disk
 > Mitch>  shutdown
 > Mitch>  ~% cat /sys/power/state
 > Mitch>  standby mem disk

Well i've not got 'platform' in my /sys/power/disk, so how do
i enable it ?

 > Mitch> Remember this worked fine in -rc2.
 >
 > Yes, but in rc3 the merge between pmdisk and swsusp1 happened.
 > It basically has totally changed between rc2 and rc3.
 >
 > So, looks like that setting is right.
 >
 > So if you wait until it's done writing out pages and hard power it
 > off, does it resume?

Well it just continues the script and reenables power to all devices,
and starts the network, spins up disk, etc, so i'm not sure it's wise
to hard power off. There's no pause inbetween.

 > Does it work if you boot with:
 > acpi=off

I don't use ACPI. My lappie only supports APM. The bios did power off
the laptop correctly in -rc2.

 > >> I wonder how many of Pavel's speed improvment patches went in with
 > >> the pmdisk/swsusp merge in rc3? I guess I can try it and see. :)
 >
 > Mitch> The speed improvement that made it stop working surely went in
 > Mitch> ;-)
 >
 > Well, thats not one we want. ;)

2.6.9-rc3 software suspend (pmdisk) stopped working

[Mitch]

Hi,

Anyone noticed that pmdisk software suspend stopped working in -rc3 ?
In -rc2 it worked just fine. My script was

  chvt 1
  echo -n shutdown >/sys/power/disk
  echo -n disk >/sys/power/state
  chvt 7

In -rc3 it appears to write pages out to disk, but never shuts down the
machine. Is there something else i need to do or am missing ?

Thanks
M

Re: 2.6.9-rc3 software suspend (pmdisk) stopped working

[Kevin Fenzi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

>>>>> "Mitch" == Mitch  <Mitch@0Bits.COM> writes:

Mitch> Hi, Anyone noticed that pmdisk software suspend stopped working
Mitch> in -rc3 ?  In -rc2 it worked just fine. My script was

Mitch>   chvt 1 echo -n shutdown >/sys/power/disk echo -n disk
Mitch> >/sys/power/state chvt 7

Mitch> In -rc3 it appears to write pages out to disk, but never shuts
Mitch> down the machine. Is there something else i need to do or am
Mitch> missing ?

What do you get from:

cat /sys/power/disk
?

If it says "platform" you might try: 

echo "shutdown" > /sys/power/disk

I wonder how many of Pavel's speed improvment patches went in with the
pmdisk/swsusp merge in rc3? I guess I can try it and see. :) 

kevin
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Processed by Mailcrypt 3.5.8 <http://mailcrypt.sourceforge.net/>

iD8DBQFBXCy83imCezTjY0ERAoZDAJ0fDwzvvl6+5o48qGmBVN2OIgXbfwCeOU2n
/AUAFfEXKKV/uW6tWTLdmd0=
=u85n
-----END PGP SIGNATURE-----

Re: 2.6.9-rc3 software suspend (pmdisk) stopped working

[Pavel Machek]

Hi!

> Mitch> Hi, Anyone noticed that pmdisk software suspend stopped working
> Mitch> in -rc3 ?  In -rc2 it worked just fine. My script was
> 
> Mitch>   chvt 1 echo -n shutdown >/sys/power/disk echo -n disk
> Mitch> >/sys/power/state chvt 7
> 
> Mitch> In -rc3 it appears to write pages out to disk, but never shuts
> Mitch> down the machine. Is there something else i need to do or am
> Mitch> missing ?
> 
> What do you get from:
> 
> cat /sys/power/disk
> ?
> 
> If it says "platform" you might try: 
> 
> echo "shutdown" > /sys/power/disk
> 
> I wonder how many of Pavel's speed improvment patches went in with the
> pmdisk/swsusp merge in rc3? I guess I can try it and see. :) 

The most important speed fix is not there, I wanted it to do take more
testing...

								Pavel
-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!

Re: 2.6.9-rc3 software suspend (pmdisk) stopped working

[Pavel Machek]

Hi!

> Anyone noticed that pmdisk software suspend stopped working in -rc3 ?
> In -rc2 it worked just fine. My script was
> 
>  chvt 1
>  echo -n shutdown >/sys/power/disk
>  echo -n disk >/sys/power/state
>  chvt 7
> 
> In -rc3 it appears to write pages out to disk, but never shuts down the
> machine. Is there something else i need to do or am missing ?

You are not missing anything, it is somehow broken. I'll try to find
out what went wrong and fix it. In the meantime, look at -mm series,
it works there.
								Pavel
-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!

Re: 2.6.9-rc3 software suspend (pmdisk) stopped working

[Kevin Fenzi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

>>>>> "Pavel" == Pavel Machek <pavel@ucw.cz> writes:

Pavel> Hi!
>> Anyone noticed that pmdisk software suspend stopped working in -rc3
>> ?  In -rc2 it worked just fine. My script was
>> 
>> chvt 1 echo -n shutdown >/sys/power/disk echo -n disk
>> >/sys/power/state chvt 7
>> 
>> In -rc3 it appears to write pages out to disk, but never shuts down
>> the machine. Is there something else i need to do or am missing ?

Pavel> You are not missing anything, it is somehow broken. I'll try to
Pavel> find out what went wrong and fix it. In the meantime, look at
Pavel> -mm series, it works there.  Pavel 

I finally had a chance to try 2.6.9-rc3 here last night. 

It suspended ok for me, but on resume it would load in the cache and
then reboot. :(

kevin
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Processed by Mailcrypt 3.5.8 <http://mailcrypt.sourceforge.net/>

iD8DBQFBXX/V3imCezTjY0ERAg41AJ4/F7ZyFibY0ZNk465IA04AXZnt3gCeNglf
HMbMUrmAEhkvkwbjP4RRqdU=
=BxrI
-----END PGP SIGNATURE-----

Re: 2.6.9-rc3 software suspend (pmdisk) stopped working

[Rafael J. Wysocki]

On Friday 01 of October 2004 18:03, Kevin Fenzi wrote:
> >>>>> "Pavel" == Pavel Machek <pavel@ucw.cz> writes:
> 
> Pavel> Hi!
> >> Anyone noticed that pmdisk software suspend stopped working in -rc3
> >> ?  In -rc2 it worked just fine. My script was
> >>
> >> chvt 1 echo -n shutdown >/sys/power/disk echo -n disk
> >> >/sys/power/state chvt 7
> >>
> >> In -rc3 it appears to write pages out to disk, but never shuts down
> >> the machine. Is there something else i need to do or am missing ?
> 
> Pavel> You are not missing anything, it is somehow broken. I'll try to
> Pavel> find out what went wrong and fix it. In the meantime, look at
> Pavel> -mm series, it works there.  Pavel
> 
> I finally had a chance to try 2.6.9-rc3 here last night.
> 
> It suspended ok for me, but on resume it would load in the cache and
> then reboot. :(

Always?  I mean, is it reproducible?  I have a similar problem, but it is not 
reproducible, apparently.  Sometimes it reboots, sometimes it reports a 
double fault, but most often it resumes just fine.

Greets,
RJW

-- 
- Would you tell me, please, which way I ought to go from here?
- That depends a good deal on where you want to get to.
		-- Lewis Carroll "Alice's Adventures in Wonderland"

Re: 2.6.9-rc3 software suspend (pmdisk) stopped working

[Kevin Fenzi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

>>>>> "Rafael" == Rafael J Wysocki <rjw@sisk.pl> writes:

Rafael> On Friday 01 of October 2004 18:03, Kevin Fenzi wrote:
>> >>>>> "Pavel" == Pavel Machek <pavel@ucw.cz> writes:
>> 
Pavel> Hi!
>> >> Anyone noticed that pmdisk software suspend stopped working in
>> -rc3 >> ?  In -rc2 it worked just fine. My script was
>> >>
>> >> chvt 1 echo -n shutdown >/sys/power/disk echo -n disk >>
>> >/sys/power/state chvt 7
>> >>
>> >> In -rc3 it appears to write pages out to disk, but never shuts
>> down >> the machine. Is there something else i need to do or am
>> missing ?
>> 
Pavel> You are not missing anything, it is somehow broken. I'll try to
Pavel> find out what went wrong and fix it. In the meantime, look at
Pavel> -mm series, it works there.  Pavel
>> I finally had a chance to try 2.6.9-rc3 here last night.
>> 
>> It suspended ok for me, but on resume it would load in the cache
>> and then reboot. :(

Rafael> Always?  I mean, is it reproducible?  I have a similar
Rafael> problem, but it is not reproducible, apparently.  Sometimes it
Rafael> reboots, sometimes it reports a double fault, but most often
Rafael> it resumes just fine.

Well, I only tried it twice, but it rebooted both times. 

After applying the patch below from Pavel on top of 2.6.9-rc3 it now
seems to work (again, I have only done a few cycles). 

Do you have HIMEM enabled? Does the patch below make it more stable
for you? 

Rafael> Greets, RJW

kevin

- --- clean/kernel/power/swsusp.c	2004-10-01 00:30:32.000000000 +0200
+++ clean-mm/kernel/power/swsusp.c	2004-09-26 01:34:27.000000000 +0200
@@ -856,7 +860,9 @@
 	local_irq_disable();
 	save_processor_state();
 	error = swsusp_arch_suspend();
+	/* Restore control flow magically appears here */
 	restore_processor_state();
+	restore_highmem();
 	local_irq_enable();
 	return error;
 }
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Processed by Mailcrypt 3.5.8 <http://mailcrypt.sourceforge.net/>

iD8DBQFBXa8q3imCezTjY0ERAv55AKCHAvg2sqBYi4p2cR+ZIJ6Y1bZeiwCfc1cN
9m/3MpImIeu1LfchBRK8LEE=
=fIt6
-----END PGP SIGNATURE-----

Re: 2.6.9-rc3 software suspend (pmdisk) stopped working

[Rafael J. Wysocki]

On Friday 01 of October 2004 21:25, Kevin Fenzi wrote:
> >>>>> "Rafael" == Rafael J Wysocki <rjw@sisk.pl> writes:
> 
> Rafael> On Friday 01 of October 2004 18:03, Kevin Fenzi wrote:
> >> >>>>> "Pavel" == Pavel Machek <pavel@ucw.cz> writes:
> >>
> Pavel> Hi!
> >> >> Anyone noticed that pmdisk software suspend stopped working in
> >> -rc3 >> ?  In -rc2 it worked just fine. My script was
> >> >>
> >> >> chvt 1 echo -n shutdown >/sys/power/disk echo -n disk >>
> >> >/sys/power/state chvt 7
> >> >>
> >> >> In -rc3 it appears to write pages out to disk, but never shuts
> >> down >> the machine. Is there something else i need to do or am
> >> missing ?
> >>
> Pavel> You are not missing anything, it is somehow broken. I'll try to
> Pavel> find out what went wrong and fix it. In the meantime, look at
> Pavel> -mm series, it works there.  Pavel
> >> I finally had a chance to try 2.6.9-rc3 here last night.
> >>
> >> It suspended ok for me, but on resume it would load in the cache
> >> and then reboot. :(
> 
> Rafael> Always?  I mean, is it reproducible?  I have a similar
> Rafael> problem, but it is not reproducible, apparently.  Sometimes it
> Rafael> reboots, sometimes it reports a double fault, but most often
> Rafael> it resumes just fine.
> 
> Well, I only tried it twice, but it rebooted both times.
> 
> After applying the patch below from Pavel on top of 2.6.9-rc3 it now
> seems to work (again, I have only done a few cycles).
> 
> Do you have HIMEM enabled?

I'm not sure what you mean.  It's an x86-64 system with 512 MB of RAM.

> Does the patch below make it more stable for you?

I have this patch applied, but I get double faults sometimes anyway.

Greets,
RJW

-- 
- Would you tell me, please, which way I ought to go from here?
- That depends a good deal on where you want to get to.
		-- Lewis Carroll "Alice's Adventures in Wonderland"

Re: 2.6.9-rc3 software suspend (pmdisk) stopped working

[Kevin Fenzi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

>>>>> "Rafael" == Rafael J Wysocki <rjw@sisk.pl> writes:

>> Do you have HIMEM enabled?

Rafael> I'm not sure what you mean.  It's an x86-64 system with 512 MB
Rafael> of RAM.

HIMEM is needed for various configs when you have 1GB of memory or
more. 

So, it shouldn't be set in your case it sounds like... 
You should have "NOHIGHMEM" set in your .config... 

>> Does the patch below make it more stable for you?

Rafael> I have this patch applied, but I get double faults sometimes
Rafael> anyway.

Can you post the exact messages? This seems diffrent than the reboot
issue I was seeing. 

Rafael> Greets, RJW

kevin

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Processed by Mailcrypt 3.5.8 <http://mailcrypt.sourceforge.net/>

iD8DBQFBXbbH3imCezTjY0ERAjWNAJ9Hl5UTfelrR+7OAGgyYLFLd+xyEQCfRv0P
MmcUi6pOW28XLO1Mh6dLlmY=
=20rC
-----END PGP SIGNATURE-----

Re: 2.6.9-rc3 software suspend (pmdisk) stopped working

[Rafael J. Wysocki]

On Friday 01 of October 2004 21:57, Kevin Fenzi wrote:
> >>>>> "Rafael" == Rafael J Wysocki <rjw@sisk.pl> writes:
> 
> >> Do you have HIMEM enabled?
> 
> Rafael> I'm not sure what you mean.  It's an x86-64 system with 512 MB
> Rafael> of RAM.
> 
> HIMEM is needed for various configs when you have 1GB of memory or
> more.
> 
> So, it shouldn't be set in your case it sounds like...
> You should have "NOHIGHMEM" set in your .config...

Well, I don't think so.  According to Documentation/x86_64/mm.txt:

"The paging design used on the x86-64 linux kernel [...] provides:

o       per process virtual address space limit of 512 Gigabytes
o       top of userspace stack located at address 0x0000007fffffffff
o       PAGE_OFFSET = 0xffff800000000000
o       start of the kernel = 0xffffffff800000000
o       global RAM per system 2^64-PAGE_OFFSET-sizeof(kernel) = 128 Terabytes 
- 2 Gigabytes
o       no need of any common code change
o       no need to use highmem to handle the 128 Terabytes of RAM"
                                                                  ^^^^^^^^^^^^^^
I have only 512 meg. ;-)

> >> Does the patch below make it more stable for you?
> 
> Rafael> I have this patch applied, but I get double faults sometimes
> Rafael> anyway.
> 
> Can you post the exact messages? This seems diffrent than the reboot
> issue I was seeing.

Sure.  They are for 2.6.9-rc2-mm4, though:

Relocating pagedir not necessary
Reading image data (9659 pages): 100% 9659 done.
Stopping tasks: ===|
Freeing memory... done (0 pages freed)
PM: Restoring saved image.
<0>double fault: 0000 [1]
CPU 0
Modules linked in: usbserial lp ohci_hcd parport_pc parport af_packet sk98lin 
ehci_hcd evdev usbhid ipv6
Pid: 17009, comm: hibernate.sh Tainted: G   M  2.6.9-rc2-mm4
RIP: 0010:[<ffffffff8012518d>] <ffffffff8012518d>{do_page_fault+1485}
RSP: 0000:000001001fe00008  EFLAGS: 00010002
RAX: 000000001fce8740 RBX: 0000000000000001 RCX: 000ffffffffff000
RDX: 000000001fce8000 RSI: 0000010000000000 RDI: 000001001fe000e8
RBP: 000001001fce8740 R08: 0000000000000000 R09: 000001001fe27e54
R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000
R13: 0000000000000000 R14: 000001001fe000e8 R15: 000001001b09e200
FS:  0000000000000000(0000) GS:ffffffff805582c0(0000) knlGS:0000000000000000
CS:  0010 DS: 0018 ES: 0018 CR0: 0000000080050033
CR2: 000001001fdffff8 CR3: 0000000000101000 CR4: 00000000000006e0
Process hibernate.sh (pid: 17009, threadinfo 000001001c6d8000, task 
000001001ad16530)
Stack: 000001001fe01000 0000000000000060 000001001ad16530 0000ffff0000001a
       fffefffefffefffe fffefffe00030001 fffefffefffefffe fffefffefffefffe
       fffefffefffefffe fffefffefffefffe
Call Trace:<ffffffff8011168d>{error_exit+0} 
<ffffffff8012518d>{do_page_fault+1485}
       <ffffffff80282d47>{acpi_os_allocate+12} 
<ffffffff8011168d>{error_exit+0}
       <ffffffff8012518d>{do_page_fault+1485} <ffffffff8011168d>{error_exit+0}
       <ffffffff8012518d>{do_page_fault+1485} 
<ffffffff80282d47>{acpi_os_allocate+12}
       <ffffffff8011168d>{error_exit+0} <ffffffff8012518d>{do_page_fault+1485}
       <ffffffff80282d47>{acpi_os_allocate+12} 
<ffffffff80282d47>{acpi_os_allocate+12}
       <ffffffff8011168d>{error_exit+0} <ffffffff8012518d>{do_page_fault+1485}
       <ffffffff80282d47>{acpi_os_allocate+12} 
<ffffffff8011168d>{error_exit+0}
       <ffffffff8012518d>{do_page_fault+1485} 
<ffffffff80282d47>{acpi_os_allocate+12}
       <ffffffff8011168d>{error_exit+0} <ffffffff8012518d>{do_page_fault+1485}
       <ffffffff8011168d>{error_exit+0} <ffffffff8012518d>{do_page_fault+1485}
       <ffffffff80282d47>{acpi_os_allocate+12} 
<ffffffff8011168d>{error_exit+0}
       <ffffffff8012518d>{do_page_fault+1485} 
<ffffffff80282d47>{acpi_os_allocate+12}
       <ffffffff8011168d>{error_exit+0} <ffffffff8012518d>{do_page_fault+1485}
       <ffffffff80282d47>{acpi_os_allocate+12} 
<ffffffff8011168d>{error_exit+0}
       <ffffffff8012518d>{do_page_fault+1485} 
<ffffffff80282d47>{acpi_os_allocate+12}
       <ffffffff8011168d>{error_exit+0} <ffffffff8012518d>{do_page_fault+1485}
       <ffffffff80282d47>{acpi_os_allocate+12} 
<ffffffff8011168d>{error_exit+0}
       <ffffffff8012518d>{do_page_fault+1485} <ffffffff8011168d>{error_exit+0}
       <ffffffff8012518d>{do_page_fault+1485} 
<ffffffff80282d47>{acpi_os_allocate+12}
       <ffffffff8011168d>{error_exit+0} <ffffffff8012518d>{do_page_fault+1485}
       <ffffffff80282d47>{acpi_os_allocate+12} 
<ffffffff80282d47>{acpi_os_allocate+12}
       <ffffffff8011168d>{error_exit+0} <ffffffff8012518d>{do_page_fault+1485}
       <ffffffff80282d47>{acpi_os_allocate+12} 
<ffffffff8011168d>{error_exit+0}
       <ffffffff8012518d>{do_page_fault+1485} 
<ffffffff80282d47>{acpi_os_allocate+12}
       <ffffffff8011168d>{error_exit+0} <ffffffff8012518d>{do_page_fault+1485}
       <ffffffff8011168d>{error_exit+0} <ffffffff8012518d>{do_page_fault+1485}
       <ffffffff80282d47>{acpi_os_allocate+12} 
<ffffffff8011168d>{error_exit+0}
       <ffffffff8012518d>{do_page_fault+1485} 
<ffffffff80282d47>{acpi_os_allocate+12}


Code: f6 04 06 81 0f 84 52 fc ff ff 48 8b 05 e2 f9 3a 00 48 89 c2
RIP <ffffffff8012518d>{do_page_fault+1485} RSP <000001001fe00008>

Greets,
RJW

-- 
- Would you tell me, please, which way I ought to go from here?
- That depends a good deal on where you want to get to.
		-- Lewis Carroll "Alice's Adventures in Wonderland"