From: Jan Dittmer <jdittmer@ppp0.net>
To: gibbs@scsiguy.com
Cc: Linux kernel <linux-kernel@vger.kernel.org>
Subject: aic7xxx remove warnings
Date: Mon, 11 Oct 2004 09:53:46 +0200 [thread overview]
Message-ID: <416A3C0A.9070606@ppp0.net> (raw)
This patch converts the aic7xxx driver to use module_param instead
of MODULE_PARM and therefore gets rid of two warning in the
non-modular build case.
Also I see there is lots of
#if LINUX_VERSION_CODE > KERNEL_VERSION(2,3,0)
checks in there. Would you accept a patch to remove those?
Thanks,
Jan
diff -u linus/drivers/scsi/aic7xxx/aic7xxx_osm.c pcirescan/drivers/scsi/aic7xxx/aic7xxx_osm.c
--- linus/drivers/scsi/aic7xxx/aic7xxx_osm.c 2004-10-06 19:58:34.000000000 +0200
+++ pcirescan/drivers/scsi/aic7xxx/aic7xxx_osm.c 2004-10-11 09:48:10.000000000 +0200
@@ -449,7 +449,7 @@
MODULE_DESCRIPTION("Adaptec Aic77XX/78XX SCSI Host Bus Adapter driver");
MODULE_LICENSE("Dual BSD/GPL");
MODULE_VERSION(AIC7XXX_DRIVER_VERSION);
-MODULE_PARM(aic7xxx, "s");
+module_param(aic7xxx, charp, 0444);
MODULE_PARM_DESC(aic7xxx,
"period delimited, options string.\n"
" verbose Enable verbose/diagnostic logging\n"
@@ -863,7 +863,6 @@
return (0);
}
ahc_linux_size_nseg();
-#ifdef MODULE
/*
* If we've been passed any parameters, process them now.
*/
@@ -875,7 +874,6 @@
"aic7xxx: to see the proper way to specify options to the aic7xxx module\n"
"aic7xxx: Specifically, don't use any commas when passing arguments to\n"
"aic7xxx: insmod or else it might trash certain memory areas.\n");
-#endif
#if LINUX_VERSION_CODE > KERNEL_VERSION(2,3,0)
template->proc_name = "aic7xxx";
reply other threads:[~2004-10-11 7:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=416A3C0A.9070606@ppp0.net \
--to=jdittmer@ppp0.net \
--cc=gibbs@scsiguy.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox