From: "Randy.Dunlap" <rddunlap@osdl.org>
To: lkml <linux-kernel@vger.kernel.org>, akpm <akpm@osdl.org>,
rmk@arm.linux.org.uk
Subject: [PATCH] cyber2000: fix init/exit section confusion
Date: Mon, 11 Oct 2004 22:29:05 -0700 [thread overview]
Message-ID: <416B6BA1.1030606@osdl.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 12 bytes --]
(attached)
[-- Attachment #2: cyber_init_exit.patch --]
[-- Type: text/x-patch, Size: 1227 bytes --]
a. cyberpro_free_fb_info() is called by both __devinit & __devexit
code, so it cannot be __devinit.
b. igs_regs[] is used by resume code (indirectly), so it cannot
be discardable.
This leaves one reference in cyber2000fb that 'make buildcheck'
complains about, but I believe that it's OK, that being ".probe"
here:
static struct pci_driver cyberpro_driver = {
.name = "CyberPro",
.probe = cyberpro_pci_probe,
Signed-off-by: Randy Dunlap <rddunlap@osdl.org>
diffstat:=
drivers/video/cyber2000fb.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff -Naurp ./drivers/video/cyber2000fb.c~cyber_init_exit ./drivers/video/cyber2000fb.c
--- ./drivers/video/cyber2000fb.c~cyber_init_exit 2004-10-11 21:10:06.930781000 -0700
+++ ./drivers/video/cyber2000fb.c 2004-10-11 22:13:16.504678864 -0700
@@ -1166,7 +1166,7 @@ static struct fb_videomode __devinitdata
.vmode = FB_VMODE_NONINTERLACED
};
-static char igs_regs[] __devinitdata = {
+static char igs_regs[] = {
EXT_CRT_IRQ, 0,
EXT_CRT_TEST, 0,
EXT_SYNC_CTL, 0,
@@ -1289,7 +1289,7 @@ cyberpro_alloc_fb_info(unsigned int id,
return cfb;
}
-static void __devinit
+static void
cyberpro_free_fb_info(struct cfb_info *cfb)
{
if (cfb) {
reply other threads:[~2004-10-12 5:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=416B6BA1.1030606@osdl.org \
--to=rddunlap@osdl.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox