From: "Prakash K. Cheemplavam" <prakashkc@gmx.de>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Jens Axboe <axboe@suse.de>, "Ronny V. Vindenes" <s864@ii.uib.no>,
ck@vds.kolivas.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@osdl.org>
Subject: Re: CFQ v2 high cpu load fix(?)
Date: Tue, 12 Oct 2004 22:44:31 +0200 [thread overview]
Message-ID: <416C422F.6030101@gmx.de> (raw)
In-Reply-To: <416BCE4A.7060403@yahoo.com.au>
[-- Attachment #1: Type: text/plain, Size: 1401 bytes --]
Nick Piggin schrieb:
> Jens Axboe wrote:
>
>> On Tue, Oct 12 2004, Nick Piggin wrote:
>>
>>> Ronny V. Vindenes wrote:
>>>
>>>>
>>>> --- patches/linux-2.6.9-rc4-ck1/drivers/block/ll_rw_blk.c
>>>> 2004-10-12 12:25:09.798003278 +0200
>>>> +++ linux-2.6.9-rc4-ck1/drivers/block/ll_rw_blk.c 2004-10-12
>>>> 12:25:42.959479479 +0200
>>>> @@ -100,7 +100,7 @@
>>>> nr = q->nr_requests;
>>>> q->nr_congestion_on = nr;
>>>>
>>>> - nr = q->nr_requests - (q->nr_requests / 8) - 1;
>>>> + nr = q->nr_requests - (q->nr_requests / 8) -
>>>> (q->nr_requests/16)- 1;
>>>> if (nr < 1)
>>>> nr = 1;
>>>> q->nr_congestion_off = nr;
>>>
>>>
>>>
>>> I thought this first hunk looked like a good idea when Arjan sent the
>>> patch. Can you check if it alone helps your problem?
>>
>>
>>
>> Yeah agree, it's a good idea to leave a bit of air between congestion on
>> and off. Fully explains the cfq v2 excessive sys time for some
>> workloads, which is extra nice.
>>
>
> Cool. Can you queue up a patch for when -mm opens again, or shall I?
> I can't imagine it should cause any problems but a bit of testing
> would be wise.
Just as a feedback: I applied the first hunk of that patch to
2.6.9-rc4-ck1 and it really makes a difference. At first I thought the
staircase scheduler was responsible for io starvation sometimes, but now
this behaviour is gone. Very well!
Prakash
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]
prev parent reply other threads:[~2004-10-12 20:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-12 11:16 CFQ v2 high cpu load fix(?) Ronny V. Vindenes
2004-10-12 11:26 ` Nick Piggin
2004-10-12 12:12 ` Jens Axboe
2004-10-12 12:30 ` Nick Piggin
2004-10-12 13:22 ` Jens Axboe
2004-10-12 13:50 ` Nick Piggin
2004-10-12 20:44 ` Prakash K. Cheemplavam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=416C422F.6030101@gmx.de \
--to=prakashkc@gmx.de \
--cc=akpm@osdl.org \
--cc=axboe@suse.de \
--cc=ck@vds.kolivas.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=s864@ii.uib.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox