Re: [patch 2/3] lsm: add bsdjail module

Andrew Morton
2004-10-07T20:08:31Z

Chris Wright <chrisw@osdl.org> wrote:
>
> * Serge E. Hallyn (serue@us.ibm.com) wrote:
> > Attached is a new version of the bsdjail patch with the requested code
> > cleanups applied.
>
> I noticed Andrew picked this up in -mm3, but that he had to do some diff
> cleanups (see the thread/rlim changes in his tree). If you'd like Andrew
> to pick this up, it would be courteous to get the diff clean and
> building against his tree.

Nah, that's OK. I can drop the old patch and pick up the new.

It's only when code is settling down into a final state that I get upset
about wholesale replacements. Even then I'll just feed it through
interdiff.

> Andrew has cleanup here (__FUNCTION__ ,). I just use __func__, anyway.

That's a workaround for the gcc-2.95 pasting bug.

__FUNCTION__ is preferred, actually. Just for consistency, and so the
compiler will spit it out if someone tries to do compile-time string
concatenation with it.