From: "Randy.Dunlap" <rddunlap@osdl.org>
To: Andrey Panin <pazke@donpac.ru>
Cc: Raj <inguva@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>, akpm <akpm@osdl.org>
Subject: [PATCH] VISWS: disable APM
Date: Thu, 14 Oct 2004 15:34:26 -0700 [thread overview]
Message-ID: <416EFEF2.8040005@osdl.org> (raw)
In-Reply-To: <21579.80.80.111.240.1097745358.squirrel@80.80.111.240>
[-- Attachment #1: Type: text/plain, Size: 1039 bytes --]
(full email thread here:
http://marc.theaimsgroup.com/?t=109758139300007&r=1&w=2
)
Andrey Panin wrote:
>>Raj wrote:
>>
>>>>>The build failed with an error 'Undefined reference to
>>>>>machine_real_restart'
>>>>
>>>>Yep, I see that also.
>>>>
>>>>>Can this be fixed ?? At the very least, hide APM options #if
>>>>>!(CONFIG_PC) ??
>>>>
>>>i am not aware much about the apm dependencies. maintainers might answer
>>>this more correctly.
>>
>>True. I should have copied Andrey on it earlier.
>>
>>Andrey, any thoughts about how to keep VISWS from building APM
>>support? use Kconfig? or does VISWS support APM?
>
> IMHO Kconfig is the best choise. VISWS has no PC compatible BIOS at all,
> it uses ARC compilant firmware for startup and configuration. Even though
> this firmware does limited BIOS emulation for running ROMs on PCI cards, i
> dont think it has working APM BIOS implementation.
Raj, can you test this patch? It WorksForMe.
It disables APM & P4THERMAL support for X86_VISWS so that VISWS
builds correctly.
--
~Randy
[-- Attachment #2: visws_noapm.patch --]
[-- Type: text/x-patch, Size: 1069 bytes --]
Prevent X86_VISWS config from building APM support.
APM isn't supported and it won't build if attempted.
Also disable P4THERMAL for VISWS.
Signed-off-by: Randy Dunlap <rddunlap@osdl.org>
diffstat:=
arch/i386/Kconfig | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff -Naurp ./arch/i386/Kconfig~visws_noapm ./arch/i386/Kconfig
--- ./arch/i386/Kconfig~visws_noapm 2004-10-11 10:54:31.019559744 -0700
+++ ./arch/i386/Kconfig 2004-10-14 09:52:24.131743344 -0700
@@ -584,7 +584,7 @@ config X86_MCE_NONFATAL
config X86_MCE_P4THERMAL
bool "check for P4 thermal throttling interrupt."
- depends on X86_MCE && (X86_UP_APIC || SMP)
+ depends on X86_MCE && (X86_UP_APIC || SMP) && !X86_VISWS
help
Enabling this feature will cause a message to be printed when the P4
enters thermal throttling.
@@ -879,7 +879,7 @@ source kernel/power/Kconfig
source "drivers/acpi/Kconfig"
menu "APM (Advanced Power Management) BIOS Support"
-depends on PM
+depends on PM && !X86_VISWS
config APM
tristate "APM (Advanced Power Management) BIOS support"
prev parent reply other threads:[~2004-10-14 22:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-12 11:38 Build problems with APM/Subarch type Raj
2004-10-13 5:11 ` Randy.Dunlap
2004-10-13 5:21 ` Ricky lloyd
2004-10-13 5:21 ` Randy.Dunlap
2004-10-13 5:27 ` Raj
2004-10-13 5:26 ` Randy.Dunlap
2004-10-14 9:15 ` Andrey Panin
2004-10-14 22:34 ` Randy.Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=416EFEF2.8040005@osdl.org \
--to=rddunlap@osdl.org \
--cc=akpm@osdl.org \
--cc=inguva@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pazke@donpac.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox