public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@linaro.org>
To: Chunyan Zhang <zhang.chunyan@linaro.org>
Cc: dwmw2@infradead.org, computersforpeace@gmail.com,
	john.stultz@linaro.org, linux-mtd@lists.infradead.org,
	linux-kernel@vger.kernel.org, zhang.lyra@gmail.com
Subject: Re: [PATCH v3] mtd: test: Replace timeval with ktime_t in speedtest.c and torturetest.c
Date: Thu, 18 Dec 2014 08:53:10 +0100	[thread overview]
Message-ID: <4170676.z5yoWA4Rtc@wuerfel> (raw)
In-Reply-To: <1418873011-4974-1-git-send-email-zhang.chunyan@linaro.org>

On Thursday 18 December 2014 11:23:31 Chunyan Zhang wrote:
> This patch changes the 32-bit time type (timeval) to the 64-bit one
> (ktime_t), since 32-bit time types will break in the year 2038.
> 
> I use ktime_t instead of timeval to define 'start' and 'finish'
> which are used to get the time for tow points.
> 
> This patch also changes do_gettimeofday() to ktime_get() accordingly,
> since ktime_get returns a ktime_t, but do_gettimeofday returns a
> struct timeval, and the other reason is that ktime_get() uses
> the monotonic clock.
> 
> This patch is based on another patch which privides a millisecond
> time difference function 'ktime_ms_delta' in ktime.h
> 
> http://lkml.iu.edu//hypermail/linux/kernel/1412.2/00625.html
> 
> Signed-off-by: Chunyan Zhang <zhang.chunyan@linaro.org>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> 

The new version still looks good to me, but as there is now a
dependency on another patch, I'd suggest we queue this up in the
y2038 branch together with the patch that introduces ktime_ms_delta.

David or Brian, can you provide an Ack for this, or do you have
any objections?

	Arnd

  reply	other threads:[~2014-12-18  7:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mtdtestv3>
2014-12-18  3:23 ` [PATCH v3] mtd: test: Replace timeval with ktime_t in speedtest.c and torturetest.c Chunyan Zhang
2014-12-18  7:53   ` Arnd Bergmann [this message]
2015-01-08  1:26     ` Brian Norris
2015-01-14  8:20       ` Chunyan Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4170676.z5yoWA4Rtc@wuerfel \
    --to=arnd@linaro.org \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=zhang.chunyan@linaro.org \
    --cc=zhang.lyra@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox