From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, ak@suse.de, axboe@suse.de
Subject: Re: Hang on x86-64, 2.6.9-rc3-bk4
Date: Sun, 17 Oct 2004 12:19:12 +1000 [thread overview]
Message-ID: <4171D6A0.4030200@yahoo.com.au> (raw)
In-Reply-To: <4171D5F8.8050504@pobox.com>
Jeff Garzik wrote:
> Nick Piggin wrote:
>
>> diff -puN mm/vmscan.c~vm-fix mm/vmscan.c
>> --- linux-2.6/mm/vmscan.c~vm-fix 2004-10-17 11:14:02.000000000 +1000
>> +++ linux-2.6-npiggin/mm/vmscan.c 2004-10-17 11:20:55.000000000 +1000
>> @@ -181,7 +181,7 @@ static int shrink_slab(unsigned long sca
>> struct shrinker *shrinker;
>>
>> if (scanned == 0)
>> - return 0;
>> + scanned = 1;
>>
>> if (!down_read_trylock(&shrinker_rwsem))
>> return 0;
>> @@ -1065,7 +1065,8 @@ scan:
>> total_reclaimed += sc.nr_reclaimed;
>> if (zone->all_unreclaimable)
>> continue;
>> - if (zone->pages_scanned > zone->present_pages * 2)
>> + if (zone->pages_scanned > (zone->nr_active +
>> + zone->nr_inactive) * 4)
>> zone->all_unreclaimable = 1;
>> /*
>> * If we've done a decent amount of scanning and
>
>
>
> Nope, this patch does not fix the hang.
>
Arrgh, sorry that should be
if (zone->pages_scanned *>=* blah)
If you've got zero LRU pages, both sides of this should be zero, and
we *want* all_unreclaimable to be set.
next prev parent reply other threads:[~2004-10-17 2:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-16 21:40 Hang on x86-64, 2.6.9-rc3-bk4 Jeff Garzik
2004-10-16 21:46 ` Jeff Garzik
2004-10-16 22:48 ` Andrew Morton
2004-10-16 23:43 ` Jeff Garzik
2004-10-17 0:14 ` Andrew Morton
2004-10-17 0:25 ` Jeff Garzik
2004-10-17 0:28 ` Andrew Morton
2004-10-17 0:51 ` Jeff Garzik
2004-10-17 1:21 ` Andrew Morton
2004-10-17 3:39 ` Jeff Garzik
2004-10-17 5:46 ` Nick Piggin
2004-10-17 13:30 ` Jeff Garzik
2004-10-17 13:49 ` Nick Piggin
2004-10-17 14:00 ` Jeff Garzik
2004-10-17 14:19 ` Nick Piggin
2004-10-17 13:31 ` Jeff Garzik
2004-10-17 1:24 ` Nick Piggin
2004-10-17 2:16 ` Jeff Garzik
2004-10-17 2:19 ` Nick Piggin [this message]
2004-10-17 2:31 ` Nick Piggin
2004-10-17 3:10 ` Jeff Garzik
2004-10-17 3:20 ` Nick Piggin
2004-10-17 3:05 ` Jeff Garzik
2004-10-17 3:07 ` Nick Piggin
2004-10-17 3:13 ` Jeff Garzik
2004-10-18 18:45 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4171D6A0.4030200@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=axboe@suse.de \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox