From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S269022AbUJQDVC (ORCPT ); Sat, 16 Oct 2004 23:21:02 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S269024AbUJQDVC (ORCPT ); Sat, 16 Oct 2004 23:21:02 -0400 Received: from smtp203.mail.sc5.yahoo.com ([216.136.129.93]:62104 "HELO smtp203.mail.sc5.yahoo.com") by vger.kernel.org with SMTP id S269022AbUJQDVA (ORCPT ); Sat, 16 Oct 2004 23:21:00 -0400 Message-ID: <4171E515.20301@yahoo.com.au> Date: Sun, 17 Oct 2004 13:20:53 +1000 From: Nick Piggin User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2) Gecko/20040820 Debian/1.7.2-4 X-Accept-Language: en MIME-Version: 1.0 To: Jeff Garzik CC: Andrew Morton , linux-kernel@vger.kernel.org, ak@suse.de, axboe@suse.de Subject: Re: Hang on x86-64, 2.6.9-rc3-bk4 References: <41719537.1080505@pobox.com> <417196AA.3090207@pobox.com> <20041016154818.271a394b.akpm@osdl.org> <4171B23F.6060305@pobox.com> <20041016171458.4511ad8b.akpm@osdl.org> <4171C20D.1000105@pobox.com> <4171C9CD.4000303@yahoo.com.au> <4171D5F8.8050504@pobox.com> <4171D6A0.4030200@yahoo.com.au> <4171D982.10605@yahoo.com.au> <4171E28D.1030805@pobox.com> In-Reply-To: <4171E28D.1030805@pobox.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Jeff Garzik wrote: > Another thing that's been bugging me... > > Is the variable 'all_zones_ok' initialized in all pertinent paths? I'm > too slack to check, but I worry, since the variable moved up one scope > level. > Yes - the for loop is going to execute at least once so there is no way to avoid the first all_zones_ok = 1;