* Patch to drivers/video/Kconfig [4 of 4]
@ 2004-10-18 9:37 Jim Nelson
2004-10-18 9:45 ` Geert Uytterhoeven
0 siblings, 1 reply; 3+ messages in thread
From: Jim Nelson @ 2004-10-18 9:37 UTC (permalink / raw)
To: Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 187 bytes --]
Fix undefined symbol errors in "make config" on architectures that do
not have I2C (sparc, primarily)
Apply against 2.6.9-rc4.
diff -u drivers/video/Kconfig.orig drivers/video/Kconfig
[-- Attachment #2: drivers_video_kconfig-fix-riva-i2c-dependency.patch --]
[-- Type: text/x-patch, Size: 1001 bytes --]
--- drivers/video/Kconfig.orig 2004-10-16 11:58:32.738491881 -0400
+++ drivers/video/Kconfig 2004-10-16 12:24:54.896505429 -0400
@@ -428,8 +428,6 @@
config FB_RIVA
tristate "nVidia Riva support"
depends on FB && PCI
- select I2C_ALGOBIT if FB_RIVA_I2C
- select I2C if FB_RIVA_I2C
select FB_MODE_HELPERS
help
This driver supports graphics boards with the nVidia Riva/Geforce
@@ -441,7 +439,7 @@
config FB_RIVA_I2C
bool "Enable DDC Support"
- depends on FB_RIVA
+ depends on FB_RIVA && I2C && I2C_ALGOBIT
help
This enables I2C support for nVidia Chipsets. This is used
only for getting EDID information from the attached display
@@ -451,6 +449,9 @@
independently validate video mode parameters, you should say Y
here.
+comment "You must enable I2C and I2C_ALGOBIT for nVidia Riva DDC Support."
+ depends on !(I2C && I2C_ALGOBIT) && FB_RIVA
+
config FB_RIVA_DEBUG
bool "Lots of debug output from Riva(nVidia) driver"
depends on FB_RIVA
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Patch to drivers/video/Kconfig [4 of 4]
2004-10-18 9:37 Patch to drivers/video/Kconfig [4 of 4] Jim Nelson
@ 2004-10-18 9:45 ` Geert Uytterhoeven
2004-10-18 9:52 ` Jim Nelson
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2004-10-18 9:45 UTC (permalink / raw)
To: Jim Nelson; +Cc: Linux Kernel Mailing List
On Mon, 18 Oct 2004, Jim Nelson wrote:
> Fix undefined symbol errors in "make config" on architectures that do
> not have I2C (sparc, primarily)
Why doesn't SPARC have i2c? If it has PCI and nVidia (and some other) graphics
cards, it has i2c.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Patch to drivers/video/Kconfig [4 of 4]
2004-10-18 9:45 ` Geert Uytterhoeven
@ 2004-10-18 9:52 ` Jim Nelson
0 siblings, 0 replies; 3+ messages in thread
From: Jim Nelson @ 2004-10-18 9:52 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Linux Kernel Mailing List
Geert Uytterhoeven wrote:
>On Mon, 18 Oct 2004, Jim Nelson wrote:
>
>
>>Fix undefined symbol errors in "make config" on architectures that do
>>not have I2C (sparc, primarily)
>>
>>
>
>Why doesn't SPARC have i2c? If it has PCI and nVidia (and some other) graphics
>cards, it has i2c.
>
>
>
It isn't included in arch/sparc/Kconfig. Would it be better to enable
I2C in the main SPARC Kconfig and mark it experimental until someone
with a SPARC32 PCI system gets a chance to test it? My SPARC system is
SBus.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-10-18 9:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-18 9:37 Patch to drivers/video/Kconfig [4 of 4] Jim Nelson
2004-10-18 9:45 ` Geert Uytterhoeven
2004-10-18 9:52 ` Jim Nelson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox