From: "Heiko Stübner" <heiko@sntech.de>
To: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Alexey Charkov <alchark@gmail.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonas Karlman <jonas@kwiboo.se>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
kernel@collabora.com, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Ye Zhang <ye.zhang@rock-chips.com>
Subject: Re: [PATCH v6 0/7] RK3576 thermal sensor support, including OTP trim adjustments
Date: Thu, 17 Jul 2025 09:21:22 +0200 [thread overview]
Message-ID: <4178173.5fSG56mABF@diego> (raw)
In-Reply-To: <aHgHxR1_Gzu8Dwbm@mai.linaro.org>
Hi Daniel,
Am Mittwoch, 16. Juli 2025, 22:12:53 Mitteleuropäische Sommerzeit schrieb Daniel Lezcano:
> On Tue, Jun 10, 2025 at 02:32:36PM +0200, Nicolas Frattaroli wrote:
> > This series adds support for the RK3576's thermal sensor.
> >
> > The sensor has six channels, providing measurements for the package
> > temperature, the temperature of the big cores, the temperature of the
> > little cores, and the GPU, NPU and DDR controller.
> >
> > In addition to adding support for the sensor itself, the series also
> > adds support for reading thermal trim values out of the device tree.
> > Most of this functionality is not specific to this SoC, but needed to be
> > implemented to make the sensors a little more accurate in order to
> > investigate whether the TRM swapped GPU and DDR or downstream swapped
> > GPU and DDR in terms of channel IDs, as downstream disagrees with what's
> > in the TRM, and the difference is so small and hard to pin down with
> > testing that the constant offset between the two sensors was a little
> > annoying for me to deal with.
> >
> > I ended up going with the channel assignment the TRM lists, as I see the
> > DDR sensor get a larger deviation from baseline temperatures during memory
> > stress tests (stress-ng --memrate 8 --memrate-flush) than what the TRM
> > claims is the GPU sensor but downstream claims is the DDR sensor. Input
> > from Rockchip engineers on whether the TRM is right or wrong welcome.
> >
> > The trim functionality is only used by RK3576 at the moment. Code to
> > handle other SoCs can rely on the shared otp reading and perhaps even
> > the IP revision specific function, but may need its own IP revision
> > specific functions added as well. Absent trim functionality in other
> > SoCs should not interfere with the modified common code paths.
> >
> > Patch 1 is a cleanup patch for the rockchip thermal driver, where a
> > function was confusingly named.
> >
> > Patch 2 adds the RK3576 compatible to the bindings.
> >
> > Patch 3 adds support for this SoC's thermal chip to the driver. It is a
> > port of the downstream commit adding support for this.
> >
> > Patch 4 adds some documentation for imminent additional functionality to
> > the binding, namely the trim value stuff.
> >
> > Patch 5 adds support for reading these OTP values in the
> > rockchip_thermal driver, and makes use of them. The code is mostly new
> > upstream code written by me, using downstream code as reference.
>
> Replaced previously applied version V5 with this V6 patches 1-5
are these commits available somewhere?
Because git.kernel.org reports that
https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git
has not seen activity in a while?
Thanks
Heiko
next prev parent reply other threads:[~2025-07-17 7:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 12:32 [PATCH v6 0/7] RK3576 thermal sensor support, including OTP trim adjustments Nicolas Frattaroli
2025-06-10 12:32 ` [PATCH v6 1/7] thermal: rockchip: rename rk_tsadcv3_tshut_mode Nicolas Frattaroli
2025-07-10 11:16 ` Heiko Stuebner
2025-06-10 12:32 ` [PATCH v6 2/7] dt-bindings: rockchip-thermal: Add RK3576 compatible Nicolas Frattaroli
2025-07-10 11:17 ` Heiko Stuebner
2025-06-10 12:32 ` [PATCH v6 3/7] thermal: rockchip: Support RK3576 SoC in the thermal driver Nicolas Frattaroli
2025-07-10 11:18 ` Heiko Stuebner
2025-06-10 12:32 ` [PATCH v6 4/7] dt-bindings: thermal: rockchip: document otp thermal trim Nicolas Frattaroli
2025-07-10 11:21 ` Heiko Stuebner
2025-07-10 19:30 ` Nicolas Frattaroli
2025-06-10 12:32 ` [PATCH v6 5/7] thermal: rockchip: support reading trim values from OTP Nicolas Frattaroli
2025-06-10 12:32 ` [PATCH v6 6/7] arm64: dts: rockchip: Add thermal nodes to RK3576 Nicolas Frattaroli
2025-06-10 12:32 ` [PATCH v6 7/7] arm64: dts: rockchip: Add thermal trim OTP and tsadc nodes Nicolas Frattaroli
2025-07-16 20:12 ` [PATCH v6 0/7] RK3576 thermal sensor support, including OTP trim adjustments Daniel Lezcano
2025-07-17 7:21 ` Heiko Stübner [this message]
2025-07-17 8:20 ` Daniel Lezcano
2025-07-31 7:33 ` Alexey Charkov
2025-07-31 8:11 ` Heiko Stübner
2025-07-31 13:27 ` Sebastian Reichel
2025-07-31 13:45 ` Heiko Stübner
2025-08-11 7:52 ` (subset) " Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4178173.5fSG56mABF@diego \
--to=heiko@sntech.de \
--cc=alchark@gmail.com \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jonas@kwiboo.se \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lukasz.luba@arm.com \
--cc=nicolas.frattaroli@collabora.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
--cc=sebastian.reichel@collabora.com \
--cc=ye.zhang@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).