__init & __initdata during resume

__init & __initdata during resume

[Randy.Dunlap]

Hi Pavel,

'make buildcheck' reports:
Error: ./arch/x86_64/ia32/syscall32.o .text refers to 0000000000000002
R_X86_64_PC32     .init.data+0x000000000000152b
Error: ./arch/x86_64/ia32/syscall32.o .text refers to 0000000000000017
R_X86_64_PC32     .init.data+0x000000000000152c


I'm looking at a recent (2 weeks) changeset:
[PATCH] Fix random crashes in x86-64 swsusp

http://linux.bkbits.net:8080/linux-2.5/cset@4166a52aYzzfOE3F63Kkb966K2Qz3g?nav=index.html|src/|src/arch|src/arch/x86_64|src/arch/x86_64/ia32|related/arch/x86_64/ia32/syscall32.c

in which this change was made:

-void __init syscall32_cpu_init(void)
+/* May not be __init: called during resume */
+void syscall32_cpu_init(void)

but syscall32_cpu_init() uses <use_sysenter>, which is:
static int use_sysenter __initdata = -1;

so the question is:  does that "__initdata" need to removed also?

--
~Randy

Re: __init & __initdata during resume

[Pavel Machek]

Hi!

> 'make buildcheck' reports:
> Error: ./arch/x86_64/ia32/syscall32.o .text refers to 0000000000000002
> R_X86_64_PC32     .init.data+0x000000000000152b
> Error: ./arch/x86_64/ia32/syscall32.o .text refers to 0000000000000017
> R_X86_64_PC32     .init.data+0x000000000000152c
> 
> 
> I'm looking at a recent (2 weeks) changeset:
> [PATCH] Fix random crashes in x86-64 swsusp
> 
> http://linux.bkbits.net:8080/linux-2.5/cset@4166a52aYzzfOE3F63Kkb966K2Qz3g?nav=index.html|src/|src/arch|src/arch/x86_64|src/arch/x86_64/ia32|related/arch/x86_64/ia32/syscall32.c
> 
> in which this change was made:
> 
> -void __init syscall32_cpu_init(void)
> +/* May not be __init: called during resume */
> +void syscall32_cpu_init(void)
> 
> but syscall32_cpu_init() uses <use_sysenter>, which is:
> static int use_sysenter __initdata = -1;
> 
> so the question is:  does that "__initdata" need to removed also?

Yes, I'm afraid that I overlooked that one.
								Pavel
-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!