Re: [PATCH 2/17] Generic backward compatibility includes for 4level

Andi Kleen
2004-10-25T17:07:37Z

On Mon, Oct 25, 2004 at 06:50:34PM +0200, Arjan van de Ven wrote:
> > >
> > > Don't we normally add do { } while (0) after empty macros which look like
> > > a function?
> >
> > iirc Rusty tried to come up with an example some time ago where it actually
> > made a difference, but failed. But I can change it.
>
>
> if (foo)
> bar();
> else
> pml4_ERROR(x);
> something_else();

Doesn't make any difference. Try it. With a double else it may make
a difference, but that is extremly bad style imho and better resolved
with a {}. Also you'll get a clear compile error.

-Andi