* [PATCH] call 'pci_dev_put' after pci_get_device
@ 2004-10-25 9:47 shaohua li
2004-10-25 13:37 ` Brian Gerst
0 siblings, 1 reply; 2+ messages in thread
From: shaohua li @ 2004-10-25 9:47 UTC (permalink / raw)
To: linux-kernel; +Cc: akpm, greg
[-- Attachment #1: Type: text/plain, Size: 1337 bytes --]
Hi,
Some code didn't call 'pci_dev_put' after pci_get_device. Below is an
incomplete list.
Thanks,
Shaohua
Signed-off-by: Li Shaohua <shaoh.li@gmail.com>
===== drivers/pci/pci.c 1.73 vs edited =====
--- 1.73/drivers/pci/pci.c 2004-10-07 00:42:55 +08:00
+++ edited/drivers/pci/pci.c 2004-10-25 17:30:36 +08:00
@@ -734,6 +734,7 @@ static int __devinit pci_init(void)
while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) {
pci_fixup_device(pci_fixup_final, dev);
+ pci_dev_put(dev);
}
return 0;
}
===== drivers/pci/quirks.c 1.55 vs edited =====
--- 1.55/drivers/pci/quirks.c 2004-10-20 00:54:38 +08:00
+++ edited/drivers/pci/quirks.c 2004-10-25 17:29:48 +08:00
@@ -38,6 +38,7 @@ static void __devinit quirk_passive_rele
dlc |= 1<<1;
pci_write_config_byte(d, 0x82, dlc);
}
+ pci_dev_put(d);
}
}
DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82441, quirk_passive_release
);
===== drivers/pci/setup-irq.c 1.5 vs edited =====
--- 1.5/drivers/pci/setup-irq.c 2004-10-07 00:44:51 +08:00
+++ edited/drivers/pci/setup-irq.c 2004-10-25 17:29:08 +08:00
@@ -67,5 +67,6 @@ pci_fixup_irqs(u8 (*swizzle)(struct pci_
struct pci_dev *dev = NULL;
while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) {
pdev_fixup_irq(dev, swizzle, map_irq);
+ pci_dev_put(dev);
}
}
[-- Attachment #2: pci_get_device.patch --]
[-- Type: application/octet-stream, Size: 1180 bytes --]
===== drivers/pci/pci.c 1.73 vs edited =====
--- 1.73/drivers/pci/pci.c 2004-10-07 00:42:55 +08:00
+++ edited/drivers/pci/pci.c 2004-10-25 17:30:36 +08:00
@@ -734,6 +734,7 @@ static int __devinit pci_init(void)
while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) {
pci_fixup_device(pci_fixup_final, dev);
+ pci_dev_put(dev);
}
return 0;
}
===== drivers/pci/quirks.c 1.55 vs edited =====
--- 1.55/drivers/pci/quirks.c 2004-10-20 00:54:38 +08:00
+++ edited/drivers/pci/quirks.c 2004-10-25 17:29:48 +08:00
@@ -38,6 +38,7 @@ static void __devinit quirk_passive_rele
dlc |= 1<<1;
pci_write_config_byte(d, 0x82, dlc);
}
+ pci_dev_put(d);
}
}
DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82441, quirk_passive_release );
===== drivers/pci/setup-irq.c 1.5 vs edited =====
--- 1.5/drivers/pci/setup-irq.c 2004-10-07 00:44:51 +08:00
+++ edited/drivers/pci/setup-irq.c 2004-10-25 17:29:08 +08:00
@@ -67,5 +67,6 @@ pci_fixup_irqs(u8 (*swizzle)(struct pci_
struct pci_dev *dev = NULL;
while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) {
pdev_fixup_irq(dev, swizzle, map_irq);
+ pci_dev_put(dev);
}
}
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] call 'pci_dev_put' after pci_get_device
2004-10-25 9:47 [PATCH] call 'pci_dev_put' after pci_get_device shaohua li
@ 2004-10-25 13:37 ` Brian Gerst
0 siblings, 0 replies; 2+ messages in thread
From: Brian Gerst @ 2004-10-25 13:37 UTC (permalink / raw)
To: shaohua li; +Cc: linux-kernel, akpm, greg
shaohua li wrote:
> Hi,
> Some code didn't call 'pci_dev_put' after pci_get_device. Below is an
> incomplete list.
>
> Thanks,
> Shaohua
If pci_get_device() is passed in a non-NULL dev it internally does a
pci_dev_put(). So if you do a complete while loop (ie. no breaks, gotos
or returns), pci_dev_put() is unnecessary.
>
> Signed-off-by: Li Shaohua <shaoh.li@gmail.com>
>
> ===== drivers/pci/pci.c 1.73 vs edited =====
> --- 1.73/drivers/pci/pci.c 2004-10-07 00:42:55 +08:00
> +++ edited/drivers/pci/pci.c 2004-10-25 17:30:36 +08:00
> @@ -734,6 +734,7 @@ static int __devinit pci_init(void)
>
> while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) {
> pci_fixup_device(pci_fixup_final, dev);
> + pci_dev_put(dev);
> }
> return 0;
> }
> ===== drivers/pci/quirks.c 1.55 vs edited =====
> --- 1.55/drivers/pci/quirks.c 2004-10-20 00:54:38 +08:00
> +++ edited/drivers/pci/quirks.c 2004-10-25 17:29:48 +08:00
> @@ -38,6 +38,7 @@ static void __devinit quirk_passive_rele
> dlc |= 1<<1;
> pci_write_config_byte(d, 0x82, dlc);
> }
> + pci_dev_put(d);
> }
> }
> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82441, quirk_passive_release
> );
> ===== drivers/pci/setup-irq.c 1.5 vs edited =====
> --- 1.5/drivers/pci/setup-irq.c 2004-10-07 00:44:51 +08:00
> +++ edited/drivers/pci/setup-irq.c 2004-10-25 17:29:08 +08:00
> @@ -67,5 +67,6 @@ pci_fixup_irqs(u8 (*swizzle)(struct pci_
> struct pci_dev *dev = NULL;
> while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) {
> pdev_fixup_irq(dev, swizzle, map_irq);
> + pci_dev_put(dev);
> }
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-10-25 13:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-25 9:47 [PATCH] call 'pci_dev_put' after pci_get_device shaohua li
2004-10-25 13:37 ` Brian Gerst
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox