* Compile breakage from me
@ 2004-10-25 17:05 Jeff Garzik
2004-10-25 17:13 ` Linus Torvalds
0 siblings, 1 reply; 5+ messages in thread
From: Jeff Garzik @ 2004-10-25 17:05 UTC (permalink / raw)
To: Linus Torvalds, Andrew Morton; +Cc: Linux Kernel, Greg KH, Hanna Linder
Argh, I thought GregKH had sent for_each_pci_dev()
Wearing a brown paper bag, can one of you please "cset -x" this changeset?
ChangeSet@1.2000.17.1, 2004-10-21 18:47:50-04:00, hannal@us.ibm.com
[PATCH] hw_random.c: replace pci_find_device
As pci_find_device is going away I've replaced it with pci_get_device.
for_each_pci_dev is a macro wrapper around pci_get_device.
If someone with this hardware could test it I would appreciate it.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Compile breakage from me
2004-10-25 17:05 Compile breakage from me Jeff Garzik
@ 2004-10-25 17:13 ` Linus Torvalds
2004-10-25 17:25 ` Linus Torvalds
0 siblings, 1 reply; 5+ messages in thread
From: Linus Torvalds @ 2004-10-25 17:13 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Andrew Morton, Linux Kernel, Greg KH, Hanna Linder
On Mon, 25 Oct 2004, Jeff Garzik wrote:
>
> Argh, I thought GregKH had sent for_each_pci_dev()
>
> Wearing a brown paper bag, can one of you please "cset -x" this changeset?
How about just sending me the for_each_pci_dev() macro instead?
Linus
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Compile breakage from me
2004-10-25 17:13 ` Linus Torvalds
@ 2004-10-25 17:25 ` Linus Torvalds
2004-10-25 17:43 ` Jeff Garzik
2004-10-25 20:20 ` Jeff Garzik
0 siblings, 2 replies; 5+ messages in thread
From: Linus Torvalds @ 2004-10-25 17:25 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Andrew Morton, Linux Kernel, Greg KH, Hanna Linder
On Mon, 25 Oct 2004, Linus Torvalds wrote:
>
> How about just sending me the for_each_pci_dev() macro instead?
Never mind. I just picked it up directly from my kernel mailing list
archives instead - Hanna had already signed off on it.
Linus
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Compile breakage from me
2004-10-25 17:25 ` Linus Torvalds
@ 2004-10-25 17:43 ` Jeff Garzik
2004-10-25 20:20 ` Jeff Garzik
1 sibling, 0 replies; 5+ messages in thread
From: Jeff Garzik @ 2004-10-25 17:43 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Andrew Morton, Linux Kernel, Greg KH, Hanna Linder
Linus Torvalds wrote:
>
> On Mon, 25 Oct 2004, Linus Torvalds wrote:
>
>>How about just sending me the for_each_pci_dev() macro instead?
>
>
> Never mind. I just picked it up directly from my kernel mailing list
> archives instead - Hanna had already signed off on it.
Thanks!
Jeff
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Compile breakage from me
2004-10-25 17:25 ` Linus Torvalds
2004-10-25 17:43 ` Jeff Garzik
@ 2004-10-25 20:20 ` Jeff Garzik
1 sibling, 0 replies; 5+ messages in thread
From: Jeff Garzik @ 2004-10-25 20:20 UTC (permalink / raw)
To: Linus Torvalds, Hanna Linder; +Cc: Andrew Morton, Linux Kernel, Greg KH
Linus Torvalds wrote:
>
> On Mon, 25 Oct 2004, Linus Torvalds wrote:
>
>>How about just sending me the for_each_pci_dev() macro instead?
>
>
> Never mind. I just picked it up directly from my kernel mailing list
> archives instead - Hanna had already signed off on it.
hmmmm, so where do the 'gotten' references go?
> --- a/drivers/char/hw_random.c 2004-10-25 16:18:50 -04:00
> +++ b/drivers/char/hw_random.c 2004-10-25 16:18:50 -04:00
> @@ -581,7 +581,7 @@
> DPRINTK ("ENTER\n");
>
> /* Probe for Intel, AMD RNGs */
> - while ((pdev = pci_find_device(PCI_ANY_ID, PCI_ANY_ID, pdev)) != NULL) {
> + for_each_pci_dev(pdev) {
> +#define for_each_pci_dev(d) while ((d = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, d)) != NULL)
Jeff
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2004-10-25 20:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-25 17:05 Compile breakage from me Jeff Garzik
2004-10-25 17:13 ` Linus Torvalds
2004-10-25 17:25 ` Linus Torvalds
2004-10-25 17:43 ` Jeff Garzik
2004-10-25 20:20 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox