From: George Anzinger <george@mvista.com>
To: Benjamin LaHaise <bcrl@kvack.org>
Cc: john stultz <johnstul@us.ibm.com>,
Linus Torvalds <torvalds@osdl.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kernel/timer.c: xtime lock missing
Date: Mon, 25 Oct 2004 16:09:51 -0700 [thread overview]
Message-ID: <417D87BF.6060803@mvista.com> (raw)
In-Reply-To: <20041021202904.GB30847@kvack.org>
Benjamin LaHaise wrote:
> On Thu, Oct 21, 2004 at 01:23:32PM -0700, john stultz wrote:
>
>>Looking at the comment above that function, the xtime_lock should
>>already be held when executing that code. timer_interrupt() should be
>>the function which grabs the lock and calls do_timer_interrupt() then
>>do_timer() then update_times().
>>
>>Or am I missing something?
>
>
> No, you're right; I'm blind. That is a very distant chain between where
> the lock is acquired and where it matters, perhaps a few more comments
> are in order.
If memory serves, there is a problem here in that the lock is taken in arch code
and not all archs are taking it. I think a check of the several arch time.c
callers might be in order.
--
George Anzinger george@mvista.com
High-res-timers: http://sourceforge.net/projects/high-res-timers/
next prev parent reply other threads:[~2004-10-26 1:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-21 19:03 [PATCH] kernel/timer.c: xtime lock missing Benjamin LaHaise
2004-10-21 20:23 ` john stultz
2004-10-21 20:29 ` Benjamin LaHaise
2004-10-25 23:09 ` George Anzinger [this message]
2004-10-26 11:04 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=417D87BF.6060803@mvista.com \
--to=george@mvista.com \
--cc=bcrl@kvack.org \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox