Re: Fw: [PATCH] Fix e100 suspend/resume w/ 2.6.10-rc1 and above (due to pci_save_state change)

Greg KH
2004-10-28T16:09:25Z

On Thu, Oct 28, 2004 at 10:59:25AM -0400, Jeff Garzik wrote:
> Greg KH wrote:
> >Huh? How did changing the pci_save_state() api change anything? I
> >didn't change the pci core any, just made it easier to not have to
> >specify the storage location of the memory to save everything off on.
>
> That could have been accomplished by moving the saved-config data
> storage into struct pci_dev

We did that a while ago.

> but not changing pci_save_state() prototype...

That was the last piece. It also fixed up some odd bugs when it was
done.

Do we really want drivers to go back to have to declare the pci config
space themselves if they want to? What does that buy us?

I agree that Ben's comments are valid, but the recent patch doesn't
change anything that wasn't already being done.

thanks,

greg k-h