From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753391AbbCAXJn (ORCPT ); Sun, 1 Mar 2015 18:09:43 -0500 Received: from gloria.sntech.de ([95.129.55.99]:57285 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753327AbbCAXJk (ORCPT ); Sun, 1 Mar 2015 18:09:40 -0500 From: Heiko Stuebner To: Krzysztof Kozlowski Cc: Russell King , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: rockchip: Constify struct regmap_config and staticize local function Date: Mon, 02 Mar 2015 00:09:34 +0100 Message-ID: <4182879.iuXeHILx18@phil> User-Agent: KMail/4.14.1 (Linux/3.19.0+; KDE/4.14.2; x86_64; ; ) In-Reply-To: <1424770727-5396-1-git-send-email-k.kozlowski@samsung.com> References: <1424770727-5396-1-git-send-email-k.kozlowski@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, Am Dienstag, 24. Februar 2015, 10:38:47 schrieb Krzysztof Kozlowski: > The regmap_config struct may be const because it is not modified by the > driver and regmap_init() accepts pointer to const. > > Make function rockchip_get_core_reset() static because it is not used > outside of the platsmp.c file. > > Signed-off-by: Krzysztof Kozlowski Added to my soc branch for 4.1 Thanks for finding these Heiko