From: Jeff Garzik <jgarzik@pobox.com>
To: Matthijs Melchior <mmelchior@xs4all.nl>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.10-rc1] ahci: Intel ICH6R (925X) corrections
Date: Sat, 30 Oct 2004 19:42:55 -0400 [thread overview]
Message-ID: <418426FF.1050801@pobox.com> (raw)
In-Reply-To: <418423C8.309@xs4all.nl>
Matthijs Melchior wrote:
> This patch makes the following changes to drivers/scsi/ahci.c
>
> - Add definition for SActive register
> - Add most interrupt sources to default interrupt mask
> - Write low 32 bits of FIS address to PxFB, where they belong
> - Set command active bit in PxSACT before setting command issue bit in PxCI
> - Announce Sub Class Code in driver info message [IDE, SATA or RAID]
>
>
> ------------------------------------------------------------------------
>
> --- a/drivers/scsi/ahci.c 2004-10-23 01:37:22.000000000 +0200
> +++ b/drivers/scsi/ahci.c 2004-10-31 00:20:13.000000000 +0200
> @@ -90,6 +90,7 @@
> PORT_SCR_STAT = 0x28, /* SATA phy register: SStatus */
> PORT_SCR_CTL = 0x2c, /* SATA phy register: SControl */
> PORT_SCR_ERR = 0x30, /* SATA phy register: SError */
> + PORT_SCR_ACT = 0x34, /* SATA phy register: SActive */
>
> /* PORT_IRQ_{STAT,MASK} bits */
> PORT_IRQ_COLD_PRES = (1 << 31), /* cold presence detect */
> @@ -116,6 +117,9 @@
> PORT_IRQ_HBUS_DATA_ERR |
> PORT_IRQ_IF_ERR,
> DEF_PORT_IRQ = PORT_IRQ_FATAL | PORT_IRQ_PHYRDY |
> + PORT_IRQ_CONNECT | PORT_IRQ_SG_DONE |
> + PORT_IRQ_UNK_FIS | PORT_IRQ_SDB_FIS |
> + PORT_IRQ_DMAS_FIS | PORT_IRQ_PIOS_FIS |
> PORT_IRQ_D2H_REG_FIS,
>
oh BTW, several parts of your patch had all the tabs converted to spaces
for some reason. I hand-converted them back.
Jeff
prev parent reply other threads:[~2004-10-30 23:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-23 15:51 2.6.10-rc1 & ahci & IHC6R & 925X & raid1 Matthijs Melchior
2004-10-25 6:18 ` Jeff Garzik
2004-10-30 23:29 ` [PATCH 2.6.10-rc1] ahci: Intel ICH6R (925X) corrections Matthijs Melchior
2004-10-30 23:41 ` Jeff Garzik
2004-10-30 23:42 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=418426FF.1050801@pobox.com \
--to=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mmelchior@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).