From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752913AbcF2PXh (ORCPT ); Wed, 29 Jun 2016 11:23:37 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:59862 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752115AbcF2PXf (ORCPT ); Wed, 29 Jun 2016 11:23:35 -0400 From: Arnd Bergmann To: Wan Zongshun Cc: linux-arm-kernel@lists.infradead.org, Russell King , devicetree@vger.kernel.org, Daniel Lezcano , Thomas Gleixner , linux-kernel@vger.kernel.org, Wan Zongshun Subject: Re: [PATCH 3/6] Clocksource: add nuc970 clocksource driver Date: Wed, 29 Jun 2016 17:25:39 +0200 Message-ID: <4184925.Jh1dkPbmzX@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1466851042-22239-4-git-send-email-vw@iommu.org> References: <1466851042-22239-1-git-send-email-vw@iommu.org> <1466851042-22239-4-git-send-email-vw@iommu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:H75ro5WqDFejf9swwluM2/riW388dEKz1DiHzxIugRUNKnPXPT8 +lhLFW8fhe/13UJLBkx3tq6uqeSD0y6LRGtyt9awb0u7hWStykr7BIR2YMgVEREateaY3lx QJPtknZGWw79+kVINyZ9JbkPwOUrEVMwYvfYp0jjid6msyKjzMHFc9BCdhuilMGYT97oZuM ec0+ygF7XVDizumkE4chg== X-UI-Out-Filterresults: notjunk:1;V01:K0:84KZU4mq5EU=:peaQmw/wnUHoEYcafL9+M5 ufEtY0gcg9D028bS5IhibVXryl0/3tuPB3M5xrIzsWKG1B7PWTiDrI/WXPtBChECV9XFENcdC 34Und78WfqwE/wkXgeFxBqP2je68cUzjIHWl+iy8/+a4CE9IXU8Wc4SR9+sPPicM5DbshAg2b vmuey90/IBSss/rfYY8rw2bVbXYCYTitXqFmR+R5Qrv34RON90zMvcJPwLW/mvTBDx2iKoCjC fhTy00q5b2VoGCxryakxdpFYXdsCwaCFHy1ajXXowiINfs2ODvCeFITUzdRZgMJwYULluDX90 bVVYJfYsSAxOtsxZtJxEHYxrcAFnf4bmfWK6Xf6RADcWtiRbwkDVl2/MnI+CLjFbxetvCUgYW Bv/TgzDoRUNr128r6bQZWdUTe0/Gaju3pPg85uQtivsGWs96aHvRQMmFvZVgnl4dqhYEbyo6G T4UkoK0FwdPF+D7kebMbsn44XxaoQWwfibCtgAF7+hnAbWuynJ9yLn5nqN/+EO/MNu9CjoBj5 OVYrirQ1UQH2CbDTPUmF2NXHeDMwdpu03+P/V8igY4Mv6ZsPzDXUgJoiS8xMxfSv74P+ElJTm 0Eia4/G+KlLEnzALkioXrojF3tCyuboDFQd6ZRo7rTLdsLjFaQ6gIgW86AFzw77Oky+hwBSfW Eu56UrUwdXeZ5p96V5+zOPTcgPfhvS1qrenLwUtfidJXh1oa5TkJTQDxfEcdwKmvwkkWb795E TpYVVSL714z9B3qN Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday, June 25, 2016 6:37:19 PM CEST Wan Zongshun wrote: > This patch is to add nuc970 clocksource driver support. > > Signed-off-by: Wan Zongshun > --- > .../mach-w90x900/include/mach/nuc970-regs-timer.h | 44 +++++ > drivers/clocksource/Kconfig | 8 + > drivers/clocksource/Makefile | 1 + > drivers/clocksource/timer-nuc900.c | 207 +++++++++++++++++++++ > 4 files changed, 260 insertions(+) > create mode 100644 arch/arm/mach-w90x900/include/mach/nuc970-regs-timer.h > create mode 100644 drivers/clocksource/timer-nuc900.c > > diff --git a/arch/arm/mach-w90x900/include/mach/nuc970-regs-timer.h b/arch/arm/mach-w90x900/include/mach/nuc970-regs-timer.h > new file mode 100644 > index 0000000..43d7e8b > --- /dev/null > +++ b/arch/arm/mach-w90x900/include/mach/nuc970-regs-timer.h Please move the contents of the header file into the driver. We try to not have any new mach/*.h headers. > + > +static unsigned int timer0_load; > +static void __iomem *tmr_base; > + > +static int nuc970_clockevent_set_oneshot(struct clock_event_device *evt) > +{ > + unsigned int val; > + > + val = __raw_readl(tmr_base + REG_TMR_TCSR0); > + val &= ~(0x03 << 27); > + > + val |= (ONESHOT | COUNTEN | INTEN | PRESCALE); > + > + __raw_writel(val, tmr_base + REG_TMR_TCSR0); > + return 0; > +} > + writel() instead of __raw_writel() Arnd