From: Jeff Garzik <jgarzik@pobox.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Andrew Morton <akpm@osdl.org>,
geert@linux-m68k.org, torvalds@osdl.org,
linux-kernel@vger.kernel.org, linux-net@vger.kernel.org
Subject: Re: [PATCH 475] HP300 LANCE
Date: Sun, 31 Oct 2004 06:58:59 -0500 [thread overview]
Message-ID: <4184D383.1090204@pobox.com> (raw)
In-Reply-To: <E1COEEO-0002lX-00@gondolin.me.apana.org.au>
Herbert Xu wrote:
> Andrew Morton <akpm@osdl.org> wrote:
>
>>Jeff Garzik <jgarzik@pobox.com> wrote:
>>
>>>On Sun, Oct 31, 2004 at 02:48:40AM -0800, Andrew Morton wrote:
>>> > > - void *va = dio_scodetoviraddr(scode);
>>> > > + unsigned long pa = dio_scodetophysaddr(scode);
>>> > > + unsigned long va = (pa + DIO_VIRADDRBASE);
>>>
>>> Did you see the above quoted patch chunk? The patch is inconsistent
>>> with _itself_, adding 'pa' and 'va' with different idents (but when they
>>> should be at the same identation level).
>>
>>Trust me ;)
>
>
> What Jeff means is that the patch is using a tab for pa and 8 spaces
> for va.
Precisely. That's what my entire "whitespace challenged" comment meant.
When the patch adds two lines at the same visual indentation level in
the source, but appear different in the patch, that is a signal that
some tabs got accidentally converted to spaces somewhere.
Jeff
next prev parent reply other threads:[~2004-10-31 12:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-31 10:03 [PATCH 475] HP300 LANCE Geert Uytterhoeven
2004-10-31 10:14 ` Jeff Garzik
2004-10-31 10:19 ` Andrew Morton
2004-10-31 10:41 ` Jeff Garzik
2004-10-31 10:48 ` Andrew Morton
2004-10-31 10:57 ` Jeff Garzik
2004-10-31 11:09 ` Andrew Morton
2004-10-31 11:44 ` Geert Uytterhoeven
2004-10-31 11:50 ` Herbert Xu
2004-10-31 11:58 ` Jeff Garzik [this message]
2004-11-01 14:22 ` Christoph Hellwig
2004-11-16 8:43 ` Christoph Hellwig
2004-11-17 7:12 ` Andrew Morton
2004-11-21 10:01 ` Geert Uytterhoeven
2004-11-21 11:19 ` Kars de Jong
2004-11-22 0:12 ` Andrew Morton
2004-11-22 0:25 ` Sohail Somani
2004-11-22 10:54 ` Geert Uytterhoeven
2004-11-22 8:26 ` Geert Uytterhoeven
-- strict thread matches above, loose matches on Subject: below --
2004-11-01 3:46 Chuck Ebbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4184D383.1090204@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=geert@linux-m68k.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox