From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752167AbcBHJ5b (ORCPT <rfc822;w@1wt.eu>);
	Mon, 8 Feb 2016 04:57:31 -0500
Received: from mout.kundenserver.de ([212.227.17.24]:54298 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751748AbcBHJ52 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 8 Feb 2016 04:57:28 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org, Jingoo Han <jingoohan1@gmail.com>,
        Pratyush Anand <pratyush.anand@gmail.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Stanimir Varbanov <svarbanov@mm-sol.com>,
        Thierry Reding <thierry.reding@gmail.com>, linux-pci@vger.kernel.org
Subject: Re: [PATCH 3/5] drivers/pci: export dw syms enabling board specific PCI code to be tristate
Date: Mon, 08 Feb 2016 10:57:17 +0100
Message-ID: <4185524.RaOx11t2l7@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1454889644-27830-4-git-send-email-paul.gortmaker@windriver.com>
References: <1454889644-27830-1-git-send-email-paul.gortmaker@windriver.com> <1454889644-27830-4-git-send-email-paul.gortmaker@windriver.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:umxO9pulLEvfVJmBSqNPGNdPITqH540ulMCRENCjecRPM6zAAa1
 VtxBT+WPvOViiF7xJMry4yOehYan7io9cXJH7Pox90X9M5p2H1g2nQpG7MQEWNJrDbdgyCZ
 AIXAuQC2Mu08O9EuSsUBuetn+NQmybdc/qotU2GI3hn6f0yJQugqNUZYPNBGM5k0YNIvyMQ
 FHaPFd9j+cizKaDuwS7eg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:8hl8nqVq2vE=:XvZWbUPyjr47X0nQ3Bave8
 F4/QOevUGqo1RSwNt6DANp65P3KwE6HHXnNqb04HjWkGmJ/tdALVsNVcLfbhxP0dPN2YQwMr4
 Sx66Bon/+UhMPBwg8NrSrCMeEgXfEsri5thBVUnrMix5lmQdCR5pWQ78L1jXH2hCG4cHwNVOB
 SbFJ2GKiUzW2yRwI8rL+479yCy0UAAM4HDEhRpay2e1lN4Q2LADL6kbe3XvdgTfcbNszrL9JN
 D5BVWJYtkykfhgbG2zVXJYc5RjoqanSB/kFiXzGF2TG+oxkWwQ2ZPi9i51CzlwKxJugYzPoln
 MFjpQkwhEQ//gv0oKTms7vKRWw8JFW55ILsrpB7rljnCZA1YINDeRizZGSyzZexSzr0e5YhSC
 zNZW++RAECyktRZaJXMcucr4xEb5q8ivp8dgBEYYnyADuLGTiJUwOEFbDvbZNXBDsD2WUNmcx
 qe140808HIUvgzGC7KlT8XNkYT1P4sLXRjsQn3ZzA+YRNSKEJi0RJexwkZjP1OY3okX81LukT
 XrAbt1qjEh9J/JK2i92dOKIFNSrnsDbIDIciq5LBfJw+Pz18RQFHgEMAqEKcTAes+Gxk1CL2p
 AtRFiYYitRO7B4yBEwkKCfjzmTdk5iIcDKU0w2lbaxlWHxeUIO5nuqUgHG9VJts1mjKMt8hQP
 6ZQlB17upVLKvNUY/b/C+XTLb8Oq3pyzC/odOD/085Idp459/V8g/XV2vdtpgyQVXNsNz7Txp
 NpPcDHvEjExHBKIl
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sunday 07 February 2016 19:00:42 Paul Gortmaker wrote:
> After converting the drivers who select PCI_DW from bool to tristate,
> the following symbols need to be exported, simply based on the output
> from modpost failures.
> 
> Cc: Jingoo Han <jingoohan1@gmail.com>
> Cc: Pratyush Anand <pratyush.anand@gmail.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Stanimir Varbanov <svarbanov@mm-sol.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: linux-pci@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> 

Looks good in principle, but maybe use EXPORT_SYMBOL_GPL? These
are just meant to be used internally by the drivers after all.

	Arnd