From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Dominik Brodowski <linux@dominikbrodowski.de>
Cc: linux-kernel@vger.kernel.org, rusty@rustcorp.com.au,
Zwane Mwaikambo <zwane@linuxpower.ca>
Subject: Re: [PATCH] [CPU-HOTPLUG] convert cpucontrol to be a rwsem
Date: Mon, 01 Nov 2004 20:05:15 +1100 [thread overview]
Message-ID: <4185FC4B.30804@yahoo.com.au> (raw)
In-Reply-To: <20041101084337.GA7824@dominikbrodowski.de>
Dominik Brodowski wrote:
> [CPU-HOTPLUG] Use a rw-semaphore for serializing and locking
>
> Currently, lock_cpu_hotplug serializes multiple calls to cpufreq->target()
> on multiple CPUs even though that's unneccessary. Even further, it
> serializes these calls with totally unrelated other parts of the kernel...
> some ppc64 event reporting, some cache management, and so on. In my opinion
> locking should be done subsystem (and normally data-)specific, and disabling
> CPU hotplug should just do that.
>
> This patch converts the semaphore cpucontrol to be a rwsem which allows us
> to use it for _both_ variants: locking (write) and (multiple) other parts
> disabling CPU hotplug (read).
>
> Only problem I see with this approach is that lock_cpu_hotplug_interruptible()
> needs to disappear as there is no down_write_interruptible() for rw-semaphores.
>
I think I've got a patch somewhere to implement _interruptible operations
on rwsems.
next prev parent reply other threads:[~2004-11-01 9:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-01 8:43 [PATCH] [CPU-HOTPLUG] convert cpucontrol to be a rwsem Dominik Brodowski
2004-11-01 9:05 ` Nick Piggin [this message]
2004-11-01 14:00 ` Zwane Mwaikambo
2004-11-01 18:04 ` Lee Revell
2004-11-01 23:48 ` Rusty Russell
2004-11-02 14:54 ` Lee Revell
2004-11-02 0:16 ` Zwane Mwaikambo
2004-11-02 22:28 ` Dominik Brodowski
2004-11-04 1:57 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4185FC4B.30804@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.de \
--cc=rusty@rustcorp.com.au \
--cc=zwane@linuxpower.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox