Re: [PATCH] [CPU-HOTPLUG] convert cpucontrol to be a rwsem

Rusty Russell
2004-11-04T04:55:38Z

On Tue, 2004-11-02 at 23:28 +0100, Dominik Brodowski wrote:
> Except that we don't want to (and can't[*]) disable preemption in the
> cpufreq case. Therefore, we __need__ to disable CPU hotplug specifically,
> and not meddle with other issues like preemption, scheduling, CPUs which are
> in the allowed_map, and so on. So back to the original patch: Rusty, do you
> agree with it?

Sure. I consider it a trivial change. The reason it wasn't a rwsem in
the first place is that there weren't many places which needed to grab
it, and none were time-sensitive.

Thanks!
Rusty.
--
A bad analogy is like a leaky screwdriver -- Richard Braakman