From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752858AbbC3OQI (ORCPT ); Mon, 30 Mar 2015 10:16:08 -0400 Received: from mx5-phx2.redhat.com ([209.132.183.37]:47360 "EHLO mx5-phx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752735AbbC3OQE (ORCPT ); Mon, 30 Mar 2015 10:16:04 -0400 Date: Mon, 30 Mar 2015 10:16:00 -0400 (EDT) From: Bob Peterson To: Chengyu Song Cc: swhiteho@redhat.com, cluster-devel@redhat.com, linux-kernel@vger.kernel.org, blee@gatech.edu, taesoo@gatech.edu, changwoo@gatech.edu, sanidhya@gatech.edu Message-ID: <418606603.5467773.1427724960573.JavaMail.zimbra@redhat.com> In-Reply-To: <1427164618-568-1-git-send-email-csong84@gatech.edu> References: <1427164618-568-1-git-send-email-csong84@gatech.edu> Subject: Re: [Cluster-devel] [PATCH 1/1] gfs2: incorrect check for debugfs returns MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.3.113.36] X-Mailer: Zimbra 8.0.6_GA_5922 (ZimbraWebClient - FF36 (Linux)/8.0.6_GA_5922) Thread-Topic: gfs2: incorrect check for debugfs returns Thread-Index: NtSgfvlToUokOBuBvf4JpPf17D5ngQ== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- Original Message ----- > debugfs_create_dir and debugfs_create_file may return -ENODEV when debugfs > is not configured, so the return value should be checked against ERROR_VALUE > as well, otherwise the later dereference of the dentry pointer would crash > the kernel. > > Signed-off-by: Chengyu Song > --- > fs/gfs2/glock.c | 47 ++++++++++++++++++++++++++++------------------- > 1 file changed, 28 insertions(+), 19 deletions(-) Hi, I've now added this patch to the for-next branch of the linux-gfs2.git tree. Thanks. Regards, Bob Peterson Red Hat File Systems