From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754538AbbILKkn (ORCPT ); Sat, 12 Sep 2015 06:40:43 -0400 Received: from gloria.sntech.de ([95.129.55.99]:54256 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751325AbbILKkl (ORCPT ); Sat, 12 Sep 2015 06:40:41 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Sjoerd Simons Cc: linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, Kumar Gala , linux-kernel@vger.kernel.org, Ian Campbell , Rob Herring , Pawel Moll , Mark Rutland , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] pinctrl: rockchip: Define GPIO banks 7 and 8 Date: Sat, 12 Sep 2015 12:40:37 +0200 Message-ID: <4186674.JafPHeXURU@diego> User-Agent: KMail/4.14.10 (Linux/4.1.0-2-amd64; KDE/4.14.10; x86_64; ; ) In-Reply-To: <1442011005-4828-1-git-send-email-sjoerd.simons@collabora.co.uk> References: <1442011005-4828-1-git-send-email-sjoerd.simons@collabora.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sjoerd, Am Samstag, 12. September 2015, 00:36:44 schrieb Sjoerd Simons: > Rockchip RK3288 has 9 GPIO banks (0 to 8) add definitions for the last > two. > > Signed-off-by: Sjoerd Simons > --- > > include/dt-bindings/pinctrl/rockchip.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/dt-bindings/pinctrl/rockchip.h > b/include/dt-bindings/pinctrl/rockchip.h index 743e66a..efc57cf 100644 > --- a/include/dt-bindings/pinctrl/rockchip.h > +++ b/include/dt-bindings/pinctrl/rockchip.h > @@ -24,6 +24,8 @@ > #define RK_GPIO3 3 > #define RK_GPIO4 4 > #define RK_GPIO6 6 > +#define RK_GPIO7 7 > +#define RK_GPIO8 8 > > #define RK_FUNC_GPIO 0 > #define RK_FUNC_1 1 I'm actually not sure about these. In retrospect the RK_GPIOx -> x defines do not provide any additional value compared to just having the actual value in the pinctrl-nodes, so we phased them out largely for the rk3288 boards. While looking through some boards, I saw that some slipped in for stuff that gets copy'n'paste treatment most of the time, but generally we're only using the real numbers on boards - and I'd like to keep it that way and phase out the RK_GPIOx constants in new boards. Heiko