Re: [PATCH] remove interactive credit

[Con Kolivas <kernel@kolivas.org>]

[-- Attachment #1: Type: text/plain, Size: 1278 bytes --]

Ingo Molnar wrote:
> * Con Kolivas <kernel@kolivas.org> wrote:
> 
> 
>>>>remove interactive credit
>>>
>>>we could try this in -mm, but it obviously needs alot of testing first. 
>>>Do you have any particular workload in mind where the fairness win due
>>>to this revert would/should be significant?
>>
>>Since I created this variable in the first place I can say with quite
>>some certainty that the size of the advantage is miniscule. Whereas
>>clearly the design introduces special case mistreatment of only one
>>type of task. It's an addition to the interactivity code I've often
>>looked at and regretted doing.
> 
> 
> yeah, i know, it was the only piece of code from your earlier -Oint
> scheduler-fixup series i almost didnt ack. But now it's in and testing
> needs to cross at least one stable kernel boundary before it can be
> taken out again. (unless a patch is an obvious or important fix.)

I've been extensively testing it at this end and recommend giving it a 
good -mm run. I'm reasonably sure it's related to some of the 
disproportionate cpu usage reports we've seen with some of those bash 
script examples (can't recall the details now so I'll need to chase them 
up). If I didn't suspect it was an issue I wouldn't be keen to undo 
something either.

Con

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 256 bytes --]