From: Con Kolivas <kernel@kolivas.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux <linux-kernel@vger.kernel.org>, Andrew Morton <akpm@osdl.org>
Subject: [PATCH] add requeue task redo
Date: Wed, 03 Nov 2004 01:00:50 +1100 [thread overview]
Message-ID: <41879312.5070009@kolivas.org> (raw)
In-Reply-To: <20041102124252.GE15290@elte.hu>
[-- Attachment #1.1: Type: text/plain, Size: 24 bytes --]
add requeue task redo
[-- Attachment #1.2: sched-add_requeue_task-1.diff --]
[-- Type: text/x-patch, Size: 1682 bytes --]
We can requeue tasks for cheaper then doing a complete dequeue followed by
an enqueue. Add the requeue_task function and perform it where possible.
Signed-off-by: Con Kolivas <kernel@kolivas.org>
Index: linux-2.6.10-rc1-mm2/kernel/sched.c
===================================================================
--- linux-2.6.10-rc1-mm2.orig/kernel/sched.c 2004-11-03 00:54:33.157137840 +1100
+++ linux-2.6.10-rc1-mm2/kernel/sched.c 2004-11-03 00:55:48.638171430 +1100
@@ -579,6 +579,16 @@ static void enqueue_task(struct task_str
}
/*
+ * Put task to the end of the run list without the overhead of dequeue
+ * followed by enqueue.
+ */
+static void requeue_task(struct task_struct *p, prio_array_t *array)
+{
+ list_del(&p->run_list);
+ list_add_tail(&p->run_list, array->queue + p->prio);
+}
+
+/*
* Used by the migration code - we pull tasks from the head of the
* remote queue so we want these tasks to show up at the head of the
* local queue:
@@ -2425,8 +2435,7 @@ void scheduler_tick(void)
set_tsk_need_resched(p);
/* put it at the end of the queue: */
- dequeue_task(p, rq->active);
- enqueue_task(p, rq->active);
+ requeue_task(p, rq->active);
}
goto out_unlock;
}
@@ -3569,8 +3578,14 @@ asmlinkage long sys_sched_yield(void)
} else if (!rq->expired->nr_active)
schedstat_inc(rq, yld_exp_empty);
- dequeue_task(current, array);
- enqueue_task(current, target);
+ if (array != target) {
+ dequeue_task(current, array);
+ enqueue_task(current, target);
+ } else
+ /*
+ * requeue_task is cheaper so perform that if possible.
+ */
+ requeue_task(current, array);
/*
* Since we are going to call schedule() anyway, there's
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 256 bytes --]
prev parent reply other threads:[~2004-11-02 14:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-02 4:07 [PATCH] add requeue task Con Kolivas
2004-11-02 12:35 ` Nick Piggin
2004-11-02 15:16 ` Nikita Danilov
2004-11-02 22:07 ` Nick Piggin
2004-11-03 8:12 ` Con Kolivas
2004-11-02 12:42 ` Ingo Molnar
2004-11-02 12:52 ` Con Kolivas
2004-11-02 12:58 ` Ingo Molnar
2004-11-02 14:02 ` [PATCH] requeue at granularity intervals Con Kolivas
2004-11-02 14:00 ` Con Kolivas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41879312.5070009@kolivas.org \
--to=kernel@kolivas.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox