From: Chris Friesen <cfriesen@nortelnetworks.com>
To: Linux kernel <linux-kernel@vger.kernel.org>
Subject: question on common error-handling idiom
Date: Tue, 02 Nov 2004 14:08:00 -0600 [thread overview]
Message-ID: <4187E920.1070302@nortelnetworks.com> (raw)
There's something I've been wondering about for a while. There is a lot of code
in linux that looks something like this:
err = -ERRORCODE
if (error condition)
goto out;
While nice to read, it would seem that it might be more efficient to do the
following:
if (error condition) {
err = -ERRORCODE;
goto out;
}
Is there any particular reason why the former is preferred? Is the compiler
smart enough to optimize away the additional write in the non-error path?
Chris
next reply other threads:[~2004-11-02 20:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-02 20:08 Chris Friesen [this message]
2004-11-02 20:58 ` question on common error-handling idiom Jan Engelhardt
2004-11-02 21:12 ` linux-os
2004-11-03 10:45 ` Ross Kendall Axe
2004-11-02 21:12 ` Russell Miller
2004-11-02 21:16 ` Jesper Juhl
2004-11-02 21:21 ` Oliver Neukum
2004-11-02 21:29 ` Jan Engelhardt
2004-11-02 21:48 ` Jesper Juhl
2004-11-03 16:49 ` Chris Friesen
2004-11-03 8:11 ` GNicz
2004-11-04 19:52 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4187E920.1070302@nortelnetworks.com \
--to=cfriesen@nortelnetworks.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox