From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Nikita Danilov <nikita@clusterfs.com>
Cc: Con Kolivas <kernel@kolivas.org>,
linux <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] add requeue task
Date: Wed, 03 Nov 2004 09:07:52 +1100 [thread overview]
Message-ID: <41880538.8090902@yahoo.com.au> (raw)
In-Reply-To: <16775.42190.9404.303359@thebsh.namesys.com>
Nikita Danilov wrote:
> Nick Piggin writes:
> > Con Kolivas wrote:
> > > add requeue task
> > > /*
> > > + * Put task to the end of the run list without the overhead of dequeue
> > > + * followed by enqueue.
> > > + */
> > > +static void requeue_task(struct task_struct *p, prio_array_t *array)
> > > +{
> > > + list_del(&p->run_list);
> > > + list_add_tail(&p->run_list, array->queue + p->prio);
> > > +}
>
> Shouldn't this be
>
> list_move_tail(&p->run_list, array->queue + p->prio);
>
> ?
>
I think it should indeed.
next prev parent reply other threads:[~2004-11-03 0:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-02 4:07 [PATCH] add requeue task Con Kolivas
2004-11-02 12:35 ` Nick Piggin
2004-11-02 15:16 ` Nikita Danilov
2004-11-02 22:07 ` Nick Piggin [this message]
2004-11-03 8:12 ` Con Kolivas
2004-11-02 12:42 ` Ingo Molnar
2004-11-02 12:52 ` Con Kolivas
2004-11-02 12:58 ` Ingo Molnar
2004-11-02 14:02 ` [PATCH] requeue at granularity intervals Con Kolivas
2004-11-02 14:00 ` [PATCH] add requeue task redo Con Kolivas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41880538.8090902@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=kernel@kolivas.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nikita@clusterfs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox