From: Jeff Garzik <jgarzik@pobox.com>
To: Chris Wedgwood <cw@f00f.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] deprecate pci_module_init
Date: Wed, 03 Nov 2004 14:13:39 -0500 [thread overview]
Message-ID: <41892DE3.5040402@pobox.com> (raw)
In-Reply-To: <20041103190757.GA25451@taniwha.stupidest.org>
Chris Wedgwood wrote:
> On Wed, Nov 03, 2004 at 12:46:40PM -0500, Jeff Garzik wrote:
>
>
>>Wrong. There are way too many __correct__ drivers to do this at
>>present.
>
>
> i could claim the same is true of MODULE_PARM yet we spew
> warning-galore there...
There is a 2.4 version of module_param().
The semantics of pci_module_init() versus pci_register_driver() are
different across 2.4/2.6. If you deprecate pci_module_init(), you are
breaking drivers which right now can be ported to 2.4 with a simple cp(1).
It's just downright silly to deprecate the API that is used most heavily
in drivers.
Jeff
next prev parent reply other threads:[~2004-11-03 19:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-03 9:10 [PATCH] deprecate pci_module_init Chris Wedgwood
2004-11-03 17:46 ` Jeff Garzik
2004-11-03 19:07 ` Chris Wedgwood
2004-11-03 19:13 ` Jeff Garzik [this message]
2004-11-03 19:20 ` Chris Wedgwood
2004-11-04 0:21 ` Greg KH
2004-11-04 0:37 ` Chris Wedgwood
2004-11-04 0:51 ` Greg KH
2004-11-04 0:53 ` Chris Wedgwood
2004-11-04 1:12 ` Jeff Garzik
2004-11-03 20:33 ` Christoph Hellwig
2004-11-03 20:49 ` Chris Wedgwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41892DE3.5040402@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=cw@f00f.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox