From: Michael Hunold <hunold@linuxtv.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Gerd Knorr <kraxel@bytesex.org>
Subject: [PATCH][V4L] keep tvaudio driver away from saa7146
Date: Thu, 04 Nov 2004 08:25:16 +0100 [thread overview]
Message-ID: <4189D95C.5000102@linuxtv.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 367 bytes --]
Hi all,
the attached patch keeps the tvaudio i2c helper module away from any
saa7146 based framegrabber. All saa7146 drivers have their dedicated i2c
helper modules and don't work together with tvaudio, so keep it away
alltogether. This will make mixed-card configurations work.
The patch was discussed and ack'ed by Gerd Knorr.
Please apply.
Thanks
Michael.
[-- Attachment #2: tvaudio.diff --]
[-- Type: text/plain, Size: 754 bytes --]
- [V4L] don't attach tvaudio module on saa7146 i2c busses
Signed-off-by: Michael Hunold <hunold@linuxtv.org>
Acked-by: Gerd Knorr <kraxel@bytesex.org>
diff -ura b/drivers/media/video/tvaudio.c linux-2.6.10-rc1-bk9-debug/drivers/media/video/tvaudio.c
--- b/drivers/media/video/tvaudio.c 2004-11-01 16:54:04.000000000 +0100
+++ linux-2.6.10-rc1-bk9-debug/drivers/media/video/tvaudio.c 2004-11-01 16:56:09.000000000 +0100
@@ -1497,6 +1497,10 @@
static int chip_probe(struct i2c_adapter *adap)
{
+ /* don't attach on saa7146 based cards,
+ because dedicated drivers are used */
+ if ((adap->id & I2C_ALGO_SAA7146))
+ return 0;
#ifdef I2C_CLASS_TV_ANALOG
if (adap->class & I2C_CLASS_TV_ANALOG)
return i2c_probe(adap, &addr_data, chip_attach);
reply other threads:[~2004-11-04 7:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4189D95C.5000102@linuxtv.org \
--to=hunold@linuxtv.org \
--cc=akpm@osdl.org \
--cc=kraxel@bytesex.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox