From: Patrick McHardy <kaber@trash.net>
To: "David S. Miller" <davem@davemloft.net>
Cc: matthias.andree@gmx.de, netfilter-devel@lists.netfilter.org,
linux-net@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [BK PATCH] Fix ip_conntrack_amanda data corruption bug that breaks amanda dumps
Date: Fri, 05 Nov 2004 01:40:39 +0100 [thread overview]
Message-ID: <418ACC07.4090104@trash.net> (raw)
In-Reply-To: <20041104160655.1c66b7ef.davem@davemloft.net>
David S. Miller wrote:
>On Fri, 05 Nov 2004 00:53:22 +0100
>Patrick McHardy <kaber@trash.net> wrote:
>
>
>
>>Your observation and your patch were correct, thanks. It is supposed
>>to be just a copy, I missed that it wasn't anymore. While your patch
>>works too, and is even faster with non-linear skbs, I don't like the
>>idea of using the skb as a scratch-area, so I sent this patch to Dave
>>instead.
>>
>>
>
>His patch isn't correct, even making a temporary change to
>a shared SKB is illegal. Things like tcpdump could see
>corrupt SKB contents if they look during that tiny window
>when the newline character has been changed to NULL by
>the amanda conntrack module.
>
>
True, I'm stupid sometimes :)
Regards
Patrick
next prev parent reply other threads:[~2004-11-05 0:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-04 12:15 [BK PATCH] Fix ip_conntrack_amanda data corruption bug that breaks amanda dumps Matthias Andree
2004-11-04 18:55 ` Patrick McHardy
2004-11-04 20:45 ` Herbert Xu
2004-11-04 21:00 ` David S. Miller
2004-11-04 21:53 ` Patrick McHardy
2004-11-04 23:50 ` Matthias Andree
2004-11-04 23:59 ` Patrick McHardy
2004-11-04 23:17 ` Matthias Andree
2004-11-04 23:53 ` Patrick McHardy
2004-11-05 0:06 ` David S. Miller
2004-11-05 0:40 ` Patrick McHardy [this message]
2004-11-05 1:04 ` Matthias Andree
2004-11-05 0:58 ` David S. Miller
2004-11-05 11:30 ` Matthias Andree
2004-11-05 20:23 ` Pablo Neira
2004-11-05 22:19 ` Patrick McHardy
2004-11-06 1:53 ` Pablo Neira
2004-11-07 12:16 ` Matthias Andree
2004-11-07 16:39 ` Patrick McHardy
2004-11-05 22:24 ` Henrik Nordstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=418ACC07.4090104@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
--cc=matthias.andree@gmx.de \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox