From: Jeff Garzik <jgarzik@pobox.com>
To: Stelian Pop <stelian@popies.net>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Dominik Brodowski <linux@dominikbrodowski.de>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH RESEND] pcmcia network drivers cleanup
Date: Thu, 04 Nov 2004 21:25:20 -0500 [thread overview]
Message-ID: <418AE490.1010304@pobox.com> (raw)
In-Reply-To: <20041104112736.GT3472@crusoe.alcove-fr>
Stelian Pop wrote:
> Hi,
>
> The attached patch:
> * cleans up the parameter passing (module_param() instead of MODULE_PARM()
> * makes debugging work (PCMCIA_DEBUG does not exist anymore, make the
> Makefile test for CONFIG_PCMCIA_DEBUG and activate DEBUG in CFLAGS)
> and use the same debugging macros for every driver through code
> reuse.
Comments:
1) Can you please separate module_param() and PCMCIA_DEBUG patches?
2) why not use pr_debug()?
Jeff
next prev parent reply other threads:[~2004-11-05 2:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-04 11:27 [PATCH RESEND] pcmcia network drivers cleanup Stelian Pop
2004-11-05 2:25 ` Jeff Garzik [this message]
2004-11-05 8:32 ` Stelian Pop
2004-11-10 15:59 ` Stelian Pop
2004-11-10 16:00 ` [PATCH] drivers/net/pcmcia: use module_param() instead of MODULE_PARM() Stelian Pop
2004-11-10 16:35 ` Randy.Dunlap
2004-11-10 19:52 ` Stelian Pop
2004-11-10 19:47 ` Randy.Dunlap
2004-11-10 21:21 ` Stelian Pop
2004-11-13 22:44 ` Dominik Brodowski
2004-11-10 16:01 ` [PATCH] drivers/net/pcmcia: rework debugging Stelian Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=418AE490.1010304@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.de \
--cc=stelian@popies.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox