Re: [PATCH RESEND] pcmcia network drivers cleanup

Jeff Garzik
2004-11-05T02:25:51Z

Stelian Pop wrote:
> Hi,
>
> The attached patch:
> * cleans up the parameter passing (module_param() instead of MODULE_PARM()
> * makes debugging work (PCMCIA_DEBUG does not exist anymore, make the
> Makefile test for CONFIG_PCMCIA_DEBUG and activate DEBUG in CFLAGS)
> and use the same debugging macros for every driver through code
> reuse.

Comments:

1) Can you please separate module_param() and PCMCIA_DEBUG patches?

2) why not use pr_debug()?

Jeff