Re: [PATCH] drivers/net/pcmcia: use module_param() instead of MODULE_PARM()

Randy.Dunlap
2004-11-10T16:47:20Z

Hi Stelian,

Several of these changes expose module parameters to sysfs
(i.e., have permissions of non-zero value) without need for that IMO.

This came up yesterday on the kernel-janitors mailing list.
When asked about it, Greg KH replied:

> Can someone please clarify the "official guidelines" for
> module parameter permissions in sysfs?

"When it makes sense to have it exposed to userspace"

Yeah, it's vague, sorry, but it all depends.

For things that can be changed on the fly, expose it.
For things that don't really matter, and no one will ever look them up,
don't. I think the irq stuff is in the "don't" category, as almost no
one messes with them anymore.
<end quote>

OTOH, debug flags are often read/write and visible, so using
0644 for them is the right thing to do.

Stelian Pop wrote:
ChangeSet@1.2090, 2004-11-10 16:43:13+01:00, stelian@popies.net
drivers/net/pcmcia: use module_param() instead of MODULE_PARM()

Signed-off-by: Stelian Pop <stelian@popies.net>

===================================================================

3c574_cs.c | 21 +++++++++++++--------
3c589_cs.c | 18 ++++++++++--------
axnet_cs.c | 11 ++++++-----
com20020_cs.c | 34 +++++++++++++++++-----------------
fmvj18x_cs.c | 15 ++++++++-------
ibmtr_cs.c | 23 ++++++++++++-----------
nmclan_cs.c | 14 ++++++++------
pcnet_cs.c | 46 +++++++++++++++++++++++++++++++++-------------
smc91c92_cs.c | 18 ++++++++++--------
xirc2ps_cs.c | 25 +++++++++++++++++--------
10 files changed, 134 insertions(+), 91 deletions(-)

===================================================================

--
~Randy