From: Jeff Garzik <jgarzik@pobox.com>
To: Chris Wedgwood <cw@f00f.org>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] WIN_* -> ATA_CMD_* conversion: add new entries to ata.h
Date: Sat, 06 Nov 2004 11:48:38 -0500 [thread overview]
Message-ID: <418D0066.9040002@pobox.com> (raw)
In-Reply-To: <20041106032305.GB6060@taniwha.stupidest.org>
Chris Wedgwood wrote:
> ===== include/linux/ata.h 1.19 vs edited =====
> --- 1.19/include/linux/ata.h 2004-11-02 11:32:44 -08:00
> +++ edited/include/linux/ata.h 2004-11-05 19:04:41 -08:00
> @@ -122,6 +122,27 @@
> ATA_CMD_SET_FEATURES = 0xEF,
> ATA_CMD_PACKET = 0xA0,
>
> + /* ATA devices commands (used by legacy IDE code) */
> + ATA_CMD_NOP = 0x00,
> + ATA_CMD_SRST = 0x08,
> + ATA_CMD_RESTORE = 0x10,
> + ATA_CMD_MULTREAD_EXT = 0x29,
> + ATA_CMD_READ_NATIVE_MAX_EXT = 0x27,
> + ATA_CMD_MULTWRITE_EXT = 0x39,
> + ATA_CMD_SPECIFY = 0x91, /* set geom */
> + ATA_CMD_SMART = 0xB0,
> + ATA_CMD_MULTREAD = 0xC4,
> + ATA_CMD_MULTWRITE = 0xC5,
> + ATA_CMD_MULTSET = 0xC6,
> + ATA_CMD_DOORLOCK = 0xDE,
> + ATA_CMD_DOORUNLOCK = 0xDF,
> + ATA_CMD_STANDBYNOW1 = 0xE0,
> + ATA_CMD_IDLEIMMEDIATE = 0xE1,
> + ATA_CMD_ID_ATA_DMA = 0xEE,
> + ATA_CMD_READ_NATIVE_MAX = 0xF8,
> + ATA_CMD_SET_MAX = 0xF9,
> + ATA_CMD_SET_MAX_EXT = 0x37,
No need for a separate "section" for ATA_CMD_xxx used by libata versus
IDE driver. ATA_CMD_xxx are just constants, available for any user.
There is no discernible order in current linux/ata.h, so feel free to
alphabetize or order by opcode (or just leave as-is).
Jeff
next prev parent reply other threads:[~2004-11-06 16:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-03 9:11 [PATCH] IDE remove some cruft from ide.h Chris Wedgwood
2004-11-05 2:43 ` Jeff Garzik
2004-11-05 13:16 ` Bartlomiej Zolnierkiewicz
2004-11-06 3:22 ` [PATCH 0/3] WIN_* -> ATA_CMD_* conversion: comments Chris Wedgwood
2004-11-06 3:23 ` [PATCH 1/3] WIN_* -> ATA_CMD_* conversion: add new entries to ata.h Chris Wedgwood
2004-11-06 16:48 ` Jeff Garzik [this message]
2004-11-06 17:05 ` Jeff Garzik
2004-11-07 6:04 ` [PATCH 0/3] WIN_* -> ATA_CMD_* conversion (take #2): comments Chris Wedgwood
2004-11-07 6:04 ` [PATCH 1/3] WIN_* -> ATA_CMD_* conversion (take #2): add new entries to ata.h Chris Wedgwood
2004-11-08 2:30 ` Jeff Garzik
2004-11-07 6:04 ` [PATCH 2/3] WIN_* -> ATA_CMD_* conversion (take #2): convert users of WIN_* to ATA_CMD_* Chris Wedgwood
2004-11-07 6:04 ` [PATCH 3/3] WIN_* -> ATA_CMD_* conversion (take #2): cleanup hdreg.h Chris Wedgwood
2004-11-06 3:23 ` [PATCH 2/3] WIN_* -> ATA_CMD_* conversion: update WIN_* users to use ATA_CMD_* Chris Wedgwood
2004-11-06 3:45 ` Ross Biro
2004-11-06 3:55 ` Chris Wedgwood
2004-11-06 14:53 ` Ross Biro
2004-11-08 8:55 ` Jens Axboe
2004-11-06 3:23 ` [PATCH 3/3] WIN_* -> ATA_CMD_* conversion: cleanup hdreg.h Chris Wedgwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=418D0066.9040002@pobox.com \
--to=jgarzik@pobox.com \
--cc=bzolnier@gmail.com \
--cc=cw@f00f.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox