* [PATCH] ata.h undefined types in USB
@ 2004-11-06 14:53 Meelis Roos
2004-11-06 18:36 ` Jeff Garzik
2004-11-06 18:40 ` Jeff Garzik
0 siblings, 2 replies; 3+ messages in thread
From: Meelis Roos @ 2004-11-06 14:53 UTC (permalink / raw)
To: Linux Kernel list
This is todays BK on a x86:
CC [M] drivers/usb/storage/freecom.o
In file included from include/linux/hdreg.h:4,
from drivers/usb/storage/freecom.c:32:
include/linux/ata.h:197: error: parse error before "u32"
...
and so on for tens of lines.
The following patch helps here because ata.h uses these types:
===== include/linux/ata.h 1.19 vs edited =====
--- 1.19/include/linux/ata.h 2004-11-02 21:32:44 +02:00
+++ edited/include/linux/ata.h 2004-11-06 16:47:08 +02:00
@@ -24,6 +24,8 @@
#ifndef __LINUX_ATA_H__
#define __LINUX_ATA_H__
+#include <linux/types.h>
+
/* defines only for the constants which don't work well as enums */
#define ATA_DMA_BOUNDARY 0xffffUL
#define ATA_DMA_MASK 0xffffffffULL
--
Meelis Roos (mroos@linux.ee)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ata.h undefined types in USB
2004-11-06 14:53 [PATCH] ata.h undefined types in USB Meelis Roos
@ 2004-11-06 18:36 ` Jeff Garzik
2004-11-06 18:40 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2004-11-06 18:36 UTC (permalink / raw)
To: Meelis Roos; +Cc: Linux Kernel list
Meelis Roos wrote:
> This is todays BK on a x86:
>
> CC [M] drivers/usb/storage/freecom.o
> In file included from include/linux/hdreg.h:4,
> from drivers/usb/storage/freecom.c:32:
> include/linux/ata.h:197: error: parse error before "u32"
> ...
> and so on for tens of lines.
I'll grab this and push upstream ASAP...
Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ata.h undefined types in USB
2004-11-06 14:53 [PATCH] ata.h undefined types in USB Meelis Roos
2004-11-06 18:36 ` Jeff Garzik
@ 2004-11-06 18:40 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2004-11-06 18:40 UTC (permalink / raw)
To: Meelis Roos; +Cc: Linux Kernel list
BTW, please include a signed-off-by line in future patches
(see http://linux.yyz.us/patch-format.html for more info)
Thanks,
Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-11-06 18:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-11-06 14:53 [PATCH] ata.h undefined types in USB Meelis Roos
2004-11-06 18:36 ` Jeff Garzik
2004-11-06 18:40 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox