public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jim Nelson <james4765@verizon.net>
To: linux-kernel@vger.kernel.org
Cc: jgarzik@pobox.com
Subject: [PATCH][resend] hw_random: Update printk()'s in hw_random.c
Date: Sat, 06 Nov 2004 13:42:14 -0500	[thread overview]
Message-ID: <418D1B06.9040201@verizon.net> (raw)

Whoops - forgot the header for this patch.

Signed-off-by: James Nelson <james4765@gmail.com>

diff -urN --exclude='*~' linux-2.6.9-original/drivers/char/hw_random.c 
linux-2.6.9/drivers/char/hw_random.c
--- linux-2.6.9-original/drivers/char/hw_random.c	2004-10-18 17:53:50.000000000 -0400
+++ linux-2.6.9/drivers/char/hw_random.c	2004-11-06 13:30:17.682633097 -0500
@@ -21,6 +21,7 @@

   */

+#undef DEBUG /* define to enable copious debugging info */

  #include <linux/module.h>
  #include <linux/kernel.h>
@@ -56,31 +57,27 @@
  /*
   * debugging macros
   */
-#undef RNG_DEBUG /* define to enable copious debugging info */

-#ifdef RNG_DEBUG
-/* note: prints function name for you */
-#define DPRINTK(fmt, args...) printk(KERN_DEBUG "%s: " fmt, __FUNCTION__ , ## args)
-#else
-#define DPRINTK(fmt, args...)
-#endif
+/* pr_debug() collapses to a no-op if DEBUG is not defined */
+#define DPRINTK(fmt, args...) pr_debug(PFX "%s: " fmt, __FUNCTION__ , ## args)
+

-#define RNG_NDEBUG        /* define to disable lightweight runtime checks */
+#undef RNG_NDEBUG        /* define to enable lightweight runtime checks */
  #ifdef RNG_NDEBUG
-#define assert(expr)
+#define assert(expr)							\
+		if(!(expr)) {						\
+		pr_debug(PFX "Assertion failed! %s,%s,%s,line=%d\n",	\
+		#expr,__FILE__,__FUNCTION__,__LINE__);			\
+		}
  #else
-#define assert(expr) \
-        if(!(expr)) {                                   \
-        printk( "Assertion failed! %s,%s,%s,line=%d\n", \
-        #expr,__FILE__,__FUNCTION__,__LINE__);          \
-        }
+#define assert(expr)
  #endif

  #define RNG_MISCDEV_MINOR		183 /* official */

  static int rng_dev_open (struct inode *inode, struct file *filp);
  static ssize_t rng_dev_read (struct file *filp, char __user *buf, size_t size,
-			     loff_t * offp);
+                 loff_t * offp);

  static int __init intel_init (struct pci_dev *dev);
  static void intel_cleanup(void);
@@ -322,7 +319,7 @@
  	rnen |= (1 << 7);	/* PMIO enable */
  	pci_write_config_byte(dev, 0x41, rnen);

-	printk(KERN_INFO PFX "AMD768 system management I/O registers at 0x%X.\n", pmbase);
+	pr_info(PFX "AMD768 system management I/O registers at 0x%X.\n",pmbase);

  	amd_dev = dev;

@@ -606,7 +603,7 @@
  	if (rc)
  		return rc;

-	printk (KERN_INFO RNG_DRIVER_NAME " loaded\n");
+	pr_info (RNG_DRIVER_NAME " loaded\n");

  	DPRINTK ("EXIT, returning 0\n");
  	return 0;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


             reply	other threads:[~2004-11-06 18:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-06 18:42 Jim Nelson [this message]
2004-11-15  0:20 ` [PATCH][resend] hw_random: Update printk()'s in hw_random.c Jeff Garzik
  -- strict thread matches above, loose matches on Subject: below --
2004-11-06 18:36 james4765

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=418D1B06.9040201@verizon.net \
    --to=james4765@verizon.net \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox