From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A43543DF019 for ; Mon, 4 May 2026 15:59:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.11 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777910385; cv=fail; b=egCjTxJ+/E6ysQDDRCaNGVDn9aVwxxfBfzYSPLyRhZEpQDOhlXRzefv6zM8nWNncLZgIEcLpamoG0o7Hd9y3qNHWErkYps/4EMetC6HSGWj1gWY0wpLlHCc1UMaIpVk+Fd7f7WQJnLNLRysMDkqh0SOxzqGRthR7h+3O1AXn/GU= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777910385; c=relaxed/simple; bh=DukuWtnr5ZF3fanzcjsZ2IX4nPqW1m5MEg5jZ7aqNUQ=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=GRU4VEgaYkqDlzXPskt5aGNxXdVM661kC5yM6OWjkDVs56k+M6L1i2UL1j9pSMMJEgiKyTHtgVxMfwF0eU4cUU/aoM8rvQWI6/Ywt6mEjvMJIxSNYJH+C35wWhDTjrNPbZmnVuutJKCgPwJTA8BtRBCmhL3Gh4HzL6oEc/eDJVQ= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=bf9tQX/E; arc=fail smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="bf9tQX/E" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777910384; x=1809446384; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=DukuWtnr5ZF3fanzcjsZ2IX4nPqW1m5MEg5jZ7aqNUQ=; b=bf9tQX/EmtE/d0YB74jPYFAN18PqR0opIk6nbXLNrerlSaluTrNPgBQZ d5Ne2AaoLP7ptlq5prz5Jtl3WkjrI2uZ0Ujcv+bg//WZacK7Oz4WMOpru cxWr83dBJ4fOdLBmszeGbjDa/wa9Y7dk/P8CDVn2BxHNpZPv1BeS9p+7D aATxz/xMBlf3fOtpbn2QHzgvuzGSRfAg8mqkWdZ9ywsUViLV1Iad0nMUu vCMPgj93Q1HgefBkzIV91PSTJ6c+gZ1nAPMRb4VxEbnbMF4Zg4qv68k4n HgKZDfu8IQkn+Nw7PhxjrjNIgKi8F+1U5ylC1UgJyR3kyP4lKd/RzcQ9r A==; X-CSE-ConnectionGUID: VgcBuyo3TgWhZzl6o5RFNw== X-CSE-MsgGUID: MMiVr62ZSlCecPsK2ik4Fw== X-IronPort-AV: E=McAfee;i="6800,10657,11776"; a="89354812" X-IronPort-AV: E=Sophos;i="6.23,215,1770624000"; d="scan'208";a="89354812" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2026 08:59:44 -0700 X-CSE-ConnectionGUID: uBHtvOSOTm2uZ5412RNErg== X-CSE-MsgGUID: rTgNL6+zQvu1LN4cUYf2FA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,215,1770624000"; d="scan'208";a="240537080" Received: from orsmsx903.amr.corp.intel.com ([10.22.229.25]) by fmviesa005.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2026 08:59:43 -0700 Received: from ORSMSX902.amr.corp.intel.com (10.22.229.24) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Mon, 4 May 2026 08:59:43 -0700 Received: from ORSEDG901.ED.cps.intel.com (10.7.248.11) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Mon, 4 May 2026 08:59:43 -0700 Received: from BYAPR05CU005.outbound.protection.outlook.com (52.101.85.46) by edgegateway.intel.com (134.134.137.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Mon, 4 May 2026 08:59:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=V3dUQ/csW3zjnEysJl421pnx5WwVSEflM3CB5se3P6b3Q4HWFR6+QxhOueNAX6UoMjIt3fmBpUz645ZZdD9fAcjv4xjPvbNHFXLRmf3Ir0ibsG55aU6w0zDFOt29GiJi/wQdl++1ZNOIQOCf/K68oWoYcVVGG/CbdCkbNQIX3Tpe9qoW6MdmPjR88Zi0UkPAphnaCXmktPu4uo+/wzfjdu8j5abe2rlHgRnwgqla/6R47+5sKXlCX0Y/3+Ein2fHjrdn7PS7l5wPPAMSjc9RAYYY7CmSgTFurbP0rNGm8jqBHF46uQpidfJtxwtJwsJRXl1ozJB/2yXwSh/JpgYeJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VPsYG6jkwxsKAg3Arun4nv3ozUZu+GV71cM+75qJBBw=; b=j9ZHn//bUXaI9VoPk/uhdd/DYQfOX+HusABwrasIwLtJwwXteUG1Aa73hKN+lAr9cHkXrhFu8tKYfqG9e4TqeceKgPb84j1oT5Rfhoux8P2lbZ/Igtajob4O4vwD9hYqe2r3ZPUTPkp6GpQYql1+aQQEzjCdA3Dt2UyRuRy0oVnAK9XxbW7tzOVwVaHkrNCkc0WMMei6+5jokR6IKtvf5/q/wqBe72MP5vcSQU/UmCtI8PrQz2xBdwaqY8TPNzTGutSrZ1TwfgXsEpTVNfBMTMGxCwW3a3L+3iFT2lKZ7aYJdMimeoS3wK1inkIQbPYurX2d+ruOkrtDbYhxFCWIqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ2PR11MB7573.namprd11.prod.outlook.com (2603:10b6:a03:4d2::10) by SJ0PR11MB6791.namprd11.prod.outlook.com (2603:10b6:a03:484::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.25; Mon, 4 May 2026 15:59:40 +0000 Received: from SJ2PR11MB7573.namprd11.prod.outlook.com ([fe80::bfe:4ce1:556:4a9d]) by SJ2PR11MB7573.namprd11.prod.outlook.com ([fe80::bfe:4ce1:556:4a9d%5]) with mapi id 15.20.9870.023; Mon, 4 May 2026 15:59:40 +0000 Message-ID: <418c4602-6e4d-40b3-b5bf-dcd1ca0c10d2@intel.com> Date: Mon, 4 May 2026 08:59:38 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/7] fs/resctrl: Tidy up the error path in resctrl_mkdir_event_configs() To: Ben Horgan , CC: , , , , , , , , , , , References: <20260428130422.2287302-1-ben.horgan@arm.com> <20260428130422.2287302-2-ben.horgan@arm.com> Content-Language: en-US From: Reinette Chatre In-Reply-To: <20260428130422.2287302-2-ben.horgan@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR03CA0144.namprd03.prod.outlook.com (2603:10b6:303:8c::29) To SJ2PR11MB7573.namprd11.prod.outlook.com (2603:10b6:a03:4d2::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR11MB7573:EE_|SJ0PR11MB6791:EE_ X-MS-Office365-Filtering-Correlation-Id: 4de1fc97-a411-43e8-92c3-08dea9f62659 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: CS/34MWq3hJGHZO3WMoO5YlTMaLZVvjhiPOXAIlq4LvQrdTgLFXXpX32Ct+N4YpcBhlFMOL8YJzDXi2Bh43gP2QHisjex5TAfp8W1QWXTbwM/+S62YiPjvP/bjTGVh0DDzolea0HMkfGREJFBl0PtYd0rfJGpUIlDCZxIBB2gikscpar76/jU2ep466ZmsF3sW134BzxbUj2WsAZYexn+Fpo9NIkuVscjp7uvhwTgi5GEqDIy99aIR4cswqS456lbvXz5ms9kP+V5kveIHHHjCxaAm2ky/ZBxx5l8KXICwsM1gJbeH61LpYw3NJ8fJr+QQcVJ+nlRGyqETnL1uwcA6x/aVpJTsncPUT/66na+cyp3Xi2dKOQCpAhzE6MaxwYi3rXqH90AQeisTDEkdpHwU0Sh5Mk4AIUnxk9dkqkGK1MV2CYz0HsHrzxgMUjkLmSrGRiMB11BWUqvkJYhmmB/V60tzAgzLH0soRWI17NHZJmJpKKMKNNBJjyiWw7wvEkj3lcvgePczj22RAQ7XoxYCSYTdxsi8h6Ohv9glqa+fNfgZ0g4FFQoun/QJEgks9zDDVtEyuO/W0DZLLOPm5PjOx1k2LAZpYsgxQSknvFRrs3WVDyWfQz3cPRnpMgG+esklSFlaODoU2QGLFHk5WCtVPMKB++C+uis9U2OuK8t1BgNKOAEwxfj7jH2CT4ynVA X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ2PR11MB7573.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dFlUQzB5R0p1cmR4dzZwdjM3S29UMkhNUURsZmh2RVpVRm5nek5vVjFJS3M4?= =?utf-8?B?RnhBVXQxQXc1WE1EUmY5WmprajU4ajJiYmxqMEhqenFYdW1kNmRTYXpGOGNq?= =?utf-8?B?b3E4TGk0RmxjR1d4YmtwUjVDcXhaKzQ2NjJSNTRYTmxSZkFPYjBYTUlrak5O?= =?utf-8?B?M3JidGhsYVRzeUZFajlXaDgzakZYUzJEY3JxNjZwbzB6SzBpRjhPOU1lSnY5?= =?utf-8?B?RmExOGNUbEhrZ3RzQXpUVXgxeGZqMkdRdjdqZW5xZlZDYS9jSFdic3NYbTlk?= =?utf-8?B?ZXVhbThPY1YrVi8rdjZmSUdhU3BYZHh5aVkxaFZPNkJWb04rL0VRdWNkQWNN?= =?utf-8?B?Tm1WVnNrSFA0VUplM0FZYXpmRXA5NThvUk1jTS95NG43emxiUkxkd2FWWFIw?= =?utf-8?B?VDNIRHVpN3c4aHg0dkdDWnEwbXdIVHhDcnBTYkc2L3FWdzFybXArQTRFR1h5?= =?utf-8?B?ZUxtN3BOa1MxU0JCT21BU3NmVm50TDVsTE9tQXh4K0NzejlKWWQ5Yy9FNnNw?= =?utf-8?B?QitzajJQd3NaOTVnQmo1bFg1UHhrdlRzYWZvMWtiMXJ5a2VZYU82RzZMcmVP?= =?utf-8?B?Q3NSMmtYSzh3djVkS0NXZkdYRlRVdE5laW9HaG1rWmVyekJEZVBhV2RoWCth?= =?utf-8?B?VzZVazlsUjVwRTJESEQ4Zk5SOE1TRjRoTFVNeHVoaU0wT1dRbEwzbzE3SjRj?= =?utf-8?B?SGJlSE9WS1ZZcDcwdmN1RlBXZUE2ajdCMkZwUk1MdEJQWXBPUENGeE81Zktw?= =?utf-8?B?N25jdWkrMlQ4YTFKQk9IN0t3Y0taNEhId2VmREJFQXZVWnBTckFWSm1makdj?= =?utf-8?B?VG5iUVIyektXdFRNeHh3bTE0SEhuL2x5b0lqQmRDSDYvWVdpc08yUHFnRWE0?= =?utf-8?B?NnY1WkE0VU83WVMyWjZEazVVOEZJUWpKbGhDbEhGcFBWQkx2OTFMNks0QjEx?= =?utf-8?B?OTFpa1laNEFSRnBBMGNsTzlKeURxWFo4azl4U0t6dG90TEZybWZJbjlUcEtr?= =?utf-8?B?aU4zRE4ralI1NVNMbTR1cXIyR3NOa0NjbDI3OFJaWW5lN3VURDhvdWMxVjlk?= =?utf-8?B?N1hnOUtsRE0wNXRKWEp4cXVGRHJyR3EyZ3d6NVhxWXBpMlpZTWJacmIya1dY?= =?utf-8?B?SzRNb2VPYjQvSXAyV3pOd1dqQ05OMldWMnR0aXc1d3dLOFVXVVlhNVZLaXIw?= =?utf-8?B?Y25nYjlGaFBrNEV1WGU2ZzhEalpXSWswZ2VlZ1ZKRHR6UHFJZ255NVo1SlZ0?= =?utf-8?B?d21LY09pVmx6MUhodUxvZWJzM3FTOTNvcnVFV2ZmbnRKcXo1Y3lHT3lSblpl?= =?utf-8?B?S1pXWDdrZlZuS2E3UHV0Q2ozU0xITU04ZURpaFltdjVna3JydjdheGFKSWFG?= =?utf-8?B?alBPSUFxM1k2dEkxT3lyWU13R2NDLzlNMzkyczJWcmVHOEpRd0ZUcEt1NGtR?= =?utf-8?B?bGVWN1BBTTJFVzRUOHY4V1QyUUI3N2FkTU9OaXlITStnU3pzTUZPckxuVHVq?= =?utf-8?B?bWpvNnFXS1dkaFFtcWJYcGtvOFpuNjZPZlA1UTZRVTJINjVkckdPMVN5Q0Fl?= =?utf-8?B?MEFwZWQvWDViZnhucnR6Z3pYYU5WT3M5YVd2ZnN3eXEzdE5IbXhNYkg5bHJu?= =?utf-8?B?cFpPRG9wN0pJK0d3U0g4eVZIeWxmQnhWRkQ1VzlwSXF5TDhkb3VuN2gxazhB?= =?utf-8?B?UHNSd2xPMFJoa2l6LytrQ1ZVdWhhOHNheDZoNksyb0pZZjVHVGpDNmZxMWJQ?= =?utf-8?B?T0RjcDZYa1M4cUxEdHZ0RHlJZmZDcWY2RXY1YVRjd1hZOTV2b3Y3eGRGVXRB?= =?utf-8?B?cEplM25JdDFqeEFWWStQZ3dwK2k1UkZoNmtMYUFuNlh2ejBvMVU3ZE1hVHN5?= =?utf-8?B?Vm1sb0ZML2dadE9tcVJGcEtVOSt4bWliMXVTL2dZSXRmUGVDMzRIMDJPMDJy?= =?utf-8?B?ODBmOG5aOHAyd1J0dkhyN09lQ05HNzAydTdOZkx2L28zWmJtMlhpaGs5Z2FE?= =?utf-8?B?S3lrSmRTS2dmNzR5UTFVRTFqYk5rWE5kNDNZeFFDeWxEaDVBcEFOdWxGUVI5?= =?utf-8?B?RWtRcmJ5eCtHQ0N6K0hpRjVxd2JpZ20rMGpLRXFjMi9xNDlpV3VlMGNUMzk2?= =?utf-8?B?Um5lQ0phNXkwQmxGb1dJVS9xQ1NDZkZsYUpVQXBZY2dCdVVjUVNDNkpWK2hE?= =?utf-8?B?c2JNdjhJSjBrTU1tN05NdS9PNmhsaWEvVVNEdTFqL3Rudy9oeTAxRitzLy9y?= =?utf-8?B?VE9kWXRyNUQweVRkY0R6a1FLYnZab1lrbHFtcm9kRFQ1eUpmdUEyRjZXUFVq?= =?utf-8?B?VVV3cXdOL1UwQ1YxQnQ4ekgxSlh4OFY4NjdDVXBMTTRUSnNERXl0UWdZYlFO?= =?utf-8?Q?0GgT5QIcyQpCkyZw=3D?= X-Exchange-RoutingPolicyChecked: VLysQ59kKMuNcTy5JWJ5hR6+tTCIM6PUGIHtnOabjGCLw9mU2YRpyCUAp11pnA+r/elD2qQL+dJdcHATWZr20oy1D5n02OpSBZEdihS+Po4Gpz/OxutVqugus+RkmRGSdBr5rt9f0pZbjNOFyzp6YmqQZdWvx/mR1LeOybYwkmKootke4x5ESknuSx8yq5SOY2ugLXGfNKQqCHL8250/DMq5X6p71G04jVlUK7NZ/BicVneL+4gsiifH42sk+FAvmEwB+zWzQhBqMY2tBZ+WciXZcwNhK+Y0qkt0RLNavps1LNOSdPIpewggwknOqRUkJfSQDKOgzaWT3q7hHvhWvA== X-MS-Exchange-CrossTenant-Network-Message-Id: 4de1fc97-a411-43e8-92c3-08dea9f62659 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2026 15:59:40.5184 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Lv8NsOnIl13QvvPxtP/93oxeqL8aAv1IfDDjd8mIaNSxVPlY9rVhgk55M5O/aHfIfQ7C6nZbkvRA7UBEx1kH6+0V10Hw1sWSiBrCvmn0un8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6791 X-OriginatorOrg: intel.com Hi Ben, On 4/28/26 6:04 AM, Ben Horgan wrote: > The error path in resctrl_mkdir_event_configs() is unnecessarily > complicated. Simplify it to just return directly on error. > > Reviewed-by: Reinette Chatre > Signed-off-by: Ben Horgan resctrl's MAINTAINERS entry recently received a "Subsystem Profile" entry to make it clear that resctrl follows the rules in the tip tree handbook. This is required since resctrl fs patches flow via the tip tree. For a smooth merge we should thus aim to follow the tip rules and for commit tag ordering this means the "Reviewed-by" tag follows the "Signed-off-by" tag. For reference, "Ordering of commit tags" in Documentation/process/maintainer-tip.rst Reinette