From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D3693B8D5C for ; Thu, 4 Jun 2026 07:07:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780556857; cv=none; b=tBJg/FOeJx1oxk8Vtv3FxIV7z/HY2izYUdf035yj9I/6ZlIZ7l18OKj6tevvJbuUJ1bxX5Ii9RoQXOq/4URwidQ3OhrYkMFCY7+QLOB/CGb9X3So0YIC2HiLY4V3dJKSEXIvcyuB48P5q2UM02YAd6USEL1HZMmXdd+Z7Kr8T4Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780556857; c=relaxed/simple; bh=dy8cCQDWGXikDQuCu/eKmyhfLPAO5i68J9FbfZ42WbA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cSshrcWkrMaf+MrwIYUmT217haDzigCYI8XWMSpknPm8iP/7/7NPIHikjpe1+g6q6bKH8UPN9aHOfo8ikshziL9Cfk1uIcpv4VcuVxapXcb94tQ3XcDzoegLwYh9YIYJ8XDbnnqs1jINiXGn/V5heo/pOEVYLDO/B36Jqajo5C4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GK1BrRAx; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GK1BrRAx" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2bf18c30bb2so2586575ad.0 for ; Thu, 04 Jun 2026 00:07:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780556854; x=1781161654; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KeCLb7DuMaDPrPdy8QMk7HQ5zSUfNkiDFhEooBB+e/A=; b=GK1BrRAxCjCdZ5tGnMjekjp4VX8YoQ8oA7UTVumvAkoFs5Stnkej02NotDi00HBw17 e3WC6aUlM1koP56+1cw8VJy/reee+jUZKomLrj1lREWbhIfv9jIsA9LaUrJ3WzzbXsgG C6E6jr1LTMmdnN13zjV1rnTEoaQT/cB/ZVmUgIWQbJRzznLXTgn4MwqwtNoeGuu5RsMU UiDyvbysLRf7HuY60zfwU7ZwHhtL4cbFsA2Z+VoIk4gEF4OXi2pqpa2dFDcRF4NS0/Tx wfieVTKDPdlEVfLVIgPhKCzDo/h2EId7KobJpnGhoZ5/1RRFdRKB9iq/s+5UhJx/NJyl snQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780556854; x=1781161654; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KeCLb7DuMaDPrPdy8QMk7HQ5zSUfNkiDFhEooBB+e/A=; b=Ua4vwLvRqtoHLfg+4yHjgRcXHOE6Ogod9/wygGOL0nBPzzC35XM9AxEowuOuFPwdMU oIWDzHJsMlT24TlIlUgTN633v/PzeFceST6lvr1CLVLReKEJ7kF4rzX5TjcS/sASxRSk wB+BlwLx/52AHA/gn8X8UUG5gyErbop6iB6etzkARenLMHEUvZoTTnEQ0wTuONltWhu3 RRUnhOXVpHBvLu6cTaM2gdYLGuS3I6+euzp2j1nBueqaIDpYCFx6NRLCajm8fNbq9J4d VYjhMIL+5ypfUcyGMQvxZ3bP9YnvNOgJ/1Bx0VzUzLmV1CCIFAknCfro8vCt/JeCHOG2 GX4Q== X-Forwarded-Encrypted: i=1; AFNElJ8NLC1V8zsHtlOGk14fCm743UudwiptVDvhmTPbg7oasnjjl14esRd3La+AP50OxYgO454EmdEe0rvQnOo=@vger.kernel.org X-Gm-Message-State: AOJu0YxmnBcjG/2zBOTMjp0elbmUvU5e0uZFNnk3tdmtmysbZDF4N+WO 7YD9PJphkl5D/QxrKSLc/dn6jvcYTZHA8whmjBJFtRrh5MpyHrjsRJ7Q X-Gm-Gg: Acq92OFKLpdPx48/ID0ScZjXfsHadvUWXbphJfzYV6Ii1oNMajamNtRZJ9pbdfmx6EC cGBHZMP9YzjxR8ZSGdgHE1k4CxuESqoqAuKluFU8BjWuUG5mshctLMkBz7LZosFiIwgfrrVjAuG AWtDSdWa59UxFtHfAnW8ISHu+MOD5e5YK5KLwgSbqmtDe8Z3rXaqjGMa3zYF0Uh1JYMzEKbfMgy y4bvAh977Ysmge5BFsKUh56TEfVcyVKIFjJzzoIQbIrDzj92YzQ/iI/rbaWFloqRn4qpgWajNrR 11OeXxETL28S+4/wwNUjHyE98Jdje3j4YWPmax3p5wbLOWekazixI9X5Ww3kruOeUZdkBMlZ+n6 1tcLUyUp7JkmOCGwFSgciAYEja75HvkV+Jg3ZoznIEIp7D1KzwSdQK3OnMdmKJSLb29c52SEOLY XRSSJic4qNrUy/zv0D7ttrscmxCY+Vxl1jJ2ADu79u/v7Qphrbg5pd0lBXwmtJ8R9soZY3EM0s6 Scd10qYxSpUdg== X-Received: by 2002:a17:903:2410:b0:2c1:737:bed9 with SMTP id d9443c01a7336-2c1644a83b5mr69929655ad.30.1780556854379; Thu, 04 Jun 2026 00:07:34 -0700 (PDT) Received: from [172.19.1.42] (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c16649ca4dsm46159235ad.76.2026.06.04.00.07.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jun 2026 00:07:33 -0700 (PDT) Message-ID: <41914879-5fd0-41dd-b097-2be80096e464@gmail.com> Date: Thu, 4 Jun 2026 15:07:31 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: spi: Add for Nuvoton MA35D1 SoC QSPI Controller To: Conor Dooley Cc: broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, cwweng@nuvoton.com References: <20260603043551.1062112-1-cwweng.linux@gmail.com> <20260603043551.1062112-2-cwweng.linux@gmail.com> <20260603-daybed-absentee-1b64f5caabe0@spud> Content-Language: en-US From: Chi-Wen Weng In-Reply-To: <20260603-daybed-absentee-1b64f5caabe0@spud> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Conor, Thanks for the review. > Missing commit message for one, but why can't your Nuvoton mail be used > here? I apologize for the missing commit message; I will add a proper description in v2. Regarding the email address, my Nuvoton mail adds a corporate confidentiality disclaimer to outgoing external mail, so I use my personal address for sending kernel patches. > Sashiko had two comments about resets and num-cs that looked valid. Noted. I will add the `num-cs` and `resets` properties in v2. > Drop this flash node, it serves no purpose here. Understood, I will remove the flash child node from the example in v2. Thanks, Chi-Wen Weng Conor Dooley 於 2026/6/3 下午 11:24 寫道: > On Wed, Jun 03, 2026 at 12:35:50PM +0800, Chi-Wen Weng wrote: >> Signed-off-by: Chi-Wen Weng > Missing commit message for one, but why can't your Nuvoton mail be used > here? > > Sashiko had two comments about resets and num-cs that looked valid. > >> --- >> .../bindings/spi/nuvoton,ma35d1-qspi.yaml | 61 +++++++++++++++++++ >> 1 file changed, 61 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/spi/nuvoton,ma35d1-qspi.yaml >> >> diff --git a/Documentation/devicetree/bindings/spi/nuvoton,ma35d1-qspi.yaml b/Documentation/devicetree/bindings/spi/nuvoton,ma35d1-qspi.yaml >> new file mode 100644 >> index 000000000000..f7b9cb52d8e5 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/spi/nuvoton,ma35d1-qspi.yaml >> @@ -0,0 +1,61 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/spi/nuvoton,ma35d1-qspi.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Nuvoton MA35D1 Quad SPI Controller >> + >> +maintainers: >> + - Chi-Wen Weng >> + >> +allOf: >> + - $ref: spi-controller.yaml# >> + >> +properties: >> + compatible: >> + const: nuvoton,ma35d1-qspi >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + - clocks >> + >> +unevaluatedProperties: false >> + >> +examples: >> + - | >> + #include >> + #include >> + >> + soc { >> + #address-cells = <2>; >> + #size-cells = <2>; >> + >> + spi@40680000 { >> + compatible = "nuvoton,ma35d1-qspi"; >> + reg = <0x0 0x40680000 0x0 0x100>; >> + interrupts = ; >> + clocks = <&clk QSPI0_GATE>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + flash@0 { > Drop this flash node, it serves no purpose here. > > pw-bot: changes-requested > > Thanks, > Conor. > >> + compatible = "jedec,spi-nor"; >> + spi-max-frequency = <30000000>; >> + reg = <0>; >> + spi-rx-bus-width = <4>; >> + spi-tx-bus-width = <1>; >> + }; >> + }; >> + }; >> + >> -- >> 2.25.1 >>