public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jim Nelson <james4765@verizon.net>
To: Neil Brown <neilb@cse.unsw.edu.au>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, mingo@redhat.com
Subject: Re: [PATCH] md: Documentation/md.txt update
Date: Tue, 09 Nov 2004 17:47:07 -0500	[thread overview]
Message-ID: <419148EB.4090907@verizon.net> (raw)
In-Reply-To: <16784.20533.56739.384864@cse.unsw.edu.au>

Neil Brown wrote:
> On Monday November 8, james4765@verizon.net wrote:
> 
>>Update status of superblock formats and fix misspellings in Documentation/md.txt
> 
> 
> Thanks but ....
> 
> 
>> 
>>-The kernel does *NOT* autodetect which format superblock is being
>>-used. It must be told.
>>+The kernel will autodetect which format superblock is being used.
> 
> 
> This is an incorrect change.  The kernel does *NOT* autodetect
> superblock format.  I'm you really think it does, please point me at
> the code.
> 
> 

AFAICT, mddev_t->major_version is used to indicate the superblock format.  That 
form is used in add_new_disk(), but not in autostart_array().

It looks like the autostart_array function is set up to only work with the 0.90.0 
superblock format, but the add_new_disk function calls the proper 
superblock-handling form using super_types[] to switch between the type 0 and type 
1 superblock formats.

OTOH, I could be wrong.

>> 
>>-One started with RUN_ARRAY, uninitialised spares can be added with
>>+One started with RUN_ARRAY, uninitialized spares can be added with
> 
> 
> You corrected the wrong part of this line.
> "One" at the beginning should be "Once".

Oops.  Missed that.

> "uninitialised" is correct  - in the Locale of the author.
> 

Do we go for Queen's English, American English, or what?  Just so I can set up the 
spell-checker in the proper locale.




      reply	other threads:[~2004-11-09 22:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-09  4:20 [PATCH] md: Documentation/md.txt update james4765
2004-11-09  5:05 ` Neil Brown
2004-11-09 22:47   ` Jim Nelson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=419148EB.4090907@verizon.net \
    --to=james4765@verizon.net \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=neilb@cse.unsw.edu.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox