From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965044AbbJVOwo (ORCPT ); Thu, 22 Oct 2015 10:52:44 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:63752 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932412AbbJVOwn (ORCPT ); Thu, 22 Oct 2015 10:52:43 -0400 From: Arnd Bergmann To: Tony Luck Cc: Anton Vorontsov , Colin Cross , Kees Cook , linux-kernel@vger.kernel.org, Geliang Tang Subject: [PATCH] pstore: remove __exit annotation for ramoops_remove Date: Thu, 22 Oct 2015 16:52:33 +0200 Message-ID: <4192179.KJLgHAoH2d@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:WFDCqIdorDZ1F2ZOqbOJ7rjRMdEmXUwSm6YmaRdKpzJBoHJJ7Mo TIBS77J+zkZHfAuIKnKHhXmxHMoE9MTtu1CuoY5eWGUpw84EKykukmCBVsFL1jQqPVm/yhx HZB0cIc1G7b23mKscBItCKaplo1sC3HRK4iG8+mEig7r19SCg+qVx20xIFRxfvWfcmuaMpr rmLraZs2PMNHrL400AOmg== X-UI-Out-Filterresults: notjunk:1;V01:K0:FCL1dmX9y4s=:6TIf69KzaEk39xVaS3TwVk e/NNWSM+o+K2LIfKfOpRprNHqek8fkxw87O4pmxQx+G+/GZgiQdaCIlr2ji0twjFb3Wv0iUWC qqOWKuYX0wR2u2WZeJH4XX62CFUXgnkUbUKAI0JBFqRAC+T9+u/K5tR4QJDk9Rin5uEWFuv4a BIzMY3xNkzh/qnDDUo7z2IcostoSn4HAdlVKBH1Q794nKEjdFSX3tymtZLvmkq3vByf/r+84s b6JG01vXDs+L+k6SaA2keLOyrV7tGX25KQ3IdW5NXoARbYgHFd+rrElTSMADd+I/QnEVa5QKW fzwru5taiyhxjsRfL3CG3qvmhBk5ii5tV+q1y4+90wE3N0HbUGqwWObpgvcAJDwj9Y3juLLzj 7N4YvHrT9w3Mrd9ljl4hIjsVZCcY/5C2PTXqqMY8d6/DJ1qV6X7gcH0K1oIi93JiwHW5cOnGD kU2RT/wtLsnXD3gnjHr3o91aPniAFNhQGXyJ0TYRFFPdUF90Z524VhO8QTEvu4eeOEusuizCw skSrBjF6mW8jRzxD8zU6if6CUHNltV1Fyq1S72iuyfVMO+W2GfExRz+jfCYdODYnQwYMlYJKg 6NJZVkJJCiuUc09QxVzWAQQl526wd7FN69MBCdFTikG1kjPRosIz8imrX6Vc4wCViwg/9rDqw q86946VyDlkTkHwcYXtTgxHNs8wA8tGBBgUJvuuVuS4RCEkKmfBm7DALhwJWhCl/qu8vlMLuq 5kvBgMPkdeRwTSzA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The remove function of a device driver should not be marked __exit, because that section gets discarded for built-in drivers, and it is still possible to manually unbind a driver from a device, which would result in a runtime error. The kernel also produces a link error for this when the module is built-in: `ramoops_remove' referenced in section `.data' of fs/built-in.o: defined in discarded section `.exit.text' of fs/built-in.o Signed-off-by: Arnd Bergmann Fixes: 2adb611ef932 ("pstore: add pstore unregister") diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c index 68889a727bc7..319c3a60cfa5 100644 --- a/fs/pstore/ram.c +++ b/fs/pstore/ram.c @@ -578,7 +578,7 @@ fail_out: return err; } -static int __exit ramoops_remove(struct platform_device *pdev) +static int ramoops_remove(struct platform_device *pdev) { struct ramoops_context *cxt = &oops_cxt;