From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix platform_rename_gsi related ia32 build breakage
Date: Wed, 10 Nov 2004 22:18:37 -0200 [thread overview]
Message-ID: <4192AFDD.3000005@conectiva.com.br> (raw)
In-Reply-To: <4192ADF4.1050907@conectiva.com.br>
[-- Attachment #1: Type: text/plain, Size: 1221 bytes --]
OK, last try, of course the patch is busted because the #endif should
be _before_ the break statement.
/me goes looking for a brown paper bag :-(
- Arnaldo
Arnaldo Carvalho de Melo wrote:
> This one compiles and links OK.
>
> - Arnaldo
>
> Arnaldo Carvalho de Melo wrote:
>
>> arch/i386/kernel/built-in.o(.text+0xeade): In function `pin_2_irq':
>> : undefined reference to `platform_rename_gsi'
>> make: ** [.tmp_vmlinux1] Erro 1
>>
>> Sorry, the patch is not enough...
>>
>> - Arnaldo
>>
>> Arnaldo Carvalho de Melo wrote:
>>
>>> Hi Linus,
>>>
>>> This is needed to build current BK tree on IA32.
>
>
> ------------------------------------------------------------------------
>
> ===== arch/i386/kernel/io_apic.c 1.116 vs edited =====
> --- 1.116/arch/i386/kernel/io_apic.c 2004-10-28 05:35:33 -03:00
> +++ edited/arch/i386/kernel/io_apic.c 2004-11-10 21:58:57 -02:00
> @@ -1069,12 +1069,14 @@
> while (i < apic)
> irq += nr_ioapic_registers[i++];
> irq += pin;
> +#ifdef CONFIG_ACPI_BOOT
> /*
> * For MPS mode, so far only used by ES7000 platform
> */
> if (platform_rename_gsi)
> irq = platform_rename_gsi(apic, irq);
> break;
> +#endif
> }
> default:
> {
[-- Attachment #2: a.patch --]
[-- Type: text/plain, Size: 488 bytes --]
===== arch/i386/kernel/io_apic.c 1.116 vs edited =====
--- 1.116/arch/i386/kernel/io_apic.c 2004-10-28 05:35:33 -03:00
+++ edited/arch/i386/kernel/io_apic.c 2004-11-10 22:17:37 -02:00
@@ -1069,11 +1069,13 @@
while (i < apic)
irq += nr_ioapic_registers[i++];
irq += pin;
+#ifdef CONFIG_ACPI_BOOT
/*
* For MPS mode, so far only used by ES7000 platform
*/
if (platform_rename_gsi)
irq = platform_rename_gsi(apic, irq);
+#endif
break;
}
default:
next prev parent reply other threads:[~2004-11-11 0:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-10 23:50 [PATCH] fix platform_rename_gsi related ia32 build breakage Arnaldo Carvalho de Melo
2004-11-10 23:52 ` Arnaldo Carvalho de Melo
2004-11-11 0:10 ` Arnaldo Carvalho de Melo
2004-11-11 0:18 ` Arnaldo Carvalho de Melo [this message]
2004-11-11 0:24 ` Linus Torvalds
2004-11-11 0:29 ` Arnaldo Carvalho de Melo
2004-11-11 22:22 ` Len Brown
2004-11-11 22:30 ` Linus Torvalds
2004-11-11 23:25 ` Len Brown
2004-11-12 0:01 ` Linus Torvalds
2004-11-12 2:50 ` Len Brown
2004-11-12 3:08 ` Linus Torvalds
2004-11-11 0:20 ` Linus Torvalds
2004-11-11 0:23 ` Arnaldo Carvalho de Melo
2004-11-11 0:38 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4192AFDD.3000005@conectiva.com.br \
--to=acme@conectiva.com.br \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox