From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>,
Rob Herring <robherring2@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Russell King <linux@arm.linux.org.uk>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
linux-kernel <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Kumar Gala <galak@codeaurora.org>,
Grant Likely <grant.likely@linaro.org>,
Fabio Estevam <festevam@gmail.com>,
Shawn Guo <shawn.guo@freescale.com>
Subject: Re: [PATCH] dt/documentation: add specification of dma bus information
Date: Fri, 20 Jun 2014 20:56:49 +0200 [thread overview]
Message-ID: <4193075.zZSpRTFEYz@wuerfel> (raw)
In-Reply-To: <53A46CB7.1030109@ti.com>
On Friday 20 June 2014 13:17:43 Santosh Shilimkar wrote:
> >> + dma-coherent;
> >> + dma-ranges;
> >> +
> >> + dwc3@2690000 {
> >> + compatible = "synopsys,dwc3";
> >> + [...]
> >> + };
> >
> > This example is a bit strange. I don't understand the relationship
> > between keystone-dwc3 and synopsys,dwc3, nor do I want to. I'd prefer
> > to see a simple example here.
> > dma-ranges is a property of the parent which you show, but
> > dma-coherent originally was a property of the bus master itself. While
> > we need to support that, are we changing that? We need to be clear on
> > where the property belongs even if the kernel is more lax.
> >
> I don't think we are changing it fundamentally but may be I missing
> your point. The dma-coherent as is now a per-device property.
> USB is one of the bus master supports coherency and hence showed
> up in above example.
I think it's enough if you just drop the "synopsys,dwc3" node and the
intermediate dma-ranges property from the example, leaving the
dma-coherent property in the "ti,keystone-dwc3" node.
Arnd
next prev parent reply other threads:[~2014-06-20 18:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 15:22 [PATCH] dt/documentation: add specification of dma bus information Santosh Shilimkar
2014-06-09 2:06 ` Shawn Guo
2014-06-09 2:13 ` Fabio Estevam
2014-06-09 13:59 ` Santosh Shilimkar
2014-06-20 15:04 ` Santosh Shilimkar
2014-06-20 15:50 ` Rob Herring
2014-06-20 17:17 ` Santosh Shilimkar
2014-06-20 18:56 ` Arnd Bergmann [this message]
2014-06-20 19:02 ` Santosh Shilimkar
2014-06-20 19:46 ` Rob Herring
2014-06-22 19:40 ` Santosh Shilimkar
2014-09-19 18:29 ` Grygorii Strashko
2014-09-26 16:32 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4193075.zZSpRTFEYz@wuerfel \
--to=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=grygorii.strashko@ti.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=robherring2@gmail.com \
--cc=santosh.shilimkar@ti.com \
--cc=shawn.guo@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox