public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] clk: sunxi: Limit legacy clocks to 32-bit ARM
@ 2022-07-02 19:01 Samuel Holland
  2022-07-02 19:01 ` [PATCH 2/2] clk: sunxi: Do not select the PRCM MFD Samuel Holland
  2022-07-02 19:09 ` [PATCH 1/2] clk: sunxi: Limit legacy clocks to 32-bit ARM Jernej Škrabec
  0 siblings, 2 replies; 5+ messages in thread
From: Samuel Holland @ 2022-07-02 19:01 UTC (permalink / raw)
  To: Chen-Yu Tsai, Jernej Skrabec, Emilio López, Stephen Boyd,
	Michael Turquette
  Cc: Samuel Holland, linux-arm-kernel, linux-clk, linux-kernel,
	linux-sunxi

The sunxi legacy clocks were never compatible with any 64-bit SoC,
so there is no point in building them as part of a 64-bit ARM kernel.
They make even less sense being built in to a 64-bit RISC-V kernel.

Signed-off-by: Samuel Holland <samuel@sholland.org>
---

 drivers/clk/sunxi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/sunxi/Kconfig b/drivers/clk/sunxi/Kconfig
index 3fba3d3ac9a2..a5c237610357 100644
--- a/drivers/clk/sunxi/Kconfig
+++ b/drivers/clk/sunxi/Kconfig
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 menuconfig CLK_SUNXI
 	bool "Legacy clock support for Allwinner SoCs"
-	depends on ARCH_SUNXI || COMPILE_TEST
+	depends on (ARM && ARCH_SUNXI) || COMPILE_TEST
 	default y
 
 if CLK_SUNXI
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] clk: sunxi: Do not select the PRCM MFD
  2022-07-02 19:01 [PATCH 1/2] clk: sunxi: Limit legacy clocks to 32-bit ARM Samuel Holland
@ 2022-07-02 19:01 ` Samuel Holland
  2022-07-02 19:10   ` Jernej Škrabec
  2022-07-02 19:09 ` [PATCH 1/2] clk: sunxi: Limit legacy clocks to 32-bit ARM Jernej Škrabec
  1 sibling, 1 reply; 5+ messages in thread
From: Samuel Holland @ 2022-07-02 19:01 UTC (permalink / raw)
  To: Chen-Yu Tsai, Jernej Skrabec, Emilio López, Stephen Boyd,
	Michael Turquette
  Cc: Samuel Holland, linux-arm-kernel, linux-clk, linux-kernel,
	linux-sunxi

The PRCM MFD driver is already selected by the two platforms where it is
actually used (MACH_SUN6I and MACH_SUN8I). Selecting it here builds it
unnecessarily on the rest of the Allwinner platforms.

Signed-off-by: Samuel Holland <samuel@sholland.org>
---

 drivers/clk/sunxi/Kconfig | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/clk/sunxi/Kconfig b/drivers/clk/sunxi/Kconfig
index a5c237610357..1c4e543366dd 100644
--- a/drivers/clk/sunxi/Kconfig
+++ b/drivers/clk/sunxi/Kconfig
@@ -19,7 +19,6 @@ config CLK_SUNXI_CLOCKS
 
 config CLK_SUNXI_PRCM_SUN6I
 	bool "Legacy A31 PRCM driver"
-	select MFD_SUN6I_PRCM
 	default y
 	help
 	  Legacy clock driver for the A31 PRCM clocks. Those are
@@ -27,7 +26,6 @@ config CLK_SUNXI_PRCM_SUN6I
 
 config CLK_SUNXI_PRCM_SUN8I
 	bool "Legacy sun8i PRCM driver"
-	select MFD_SUN6I_PRCM
 	default y
 	help
 	  Legacy clock driver for the sun8i family PRCM clocks.
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] clk: sunxi: Limit legacy clocks to 32-bit ARM
  2022-07-02 19:01 [PATCH 1/2] clk: sunxi: Limit legacy clocks to 32-bit ARM Samuel Holland
  2022-07-02 19:01 ` [PATCH 2/2] clk: sunxi: Do not select the PRCM MFD Samuel Holland
@ 2022-07-02 19:09 ` Jernej Škrabec
  2022-07-04 20:05   ` Jernej Škrabec
  1 sibling, 1 reply; 5+ messages in thread
From: Jernej Škrabec @ 2022-07-02 19:09 UTC (permalink / raw)
  To: Chen-Yu Tsai, Emilio López, Stephen Boyd, Michael Turquette,
	Samuel Holland
  Cc: Samuel Holland, linux-arm-kernel, linux-clk, linux-kernel,
	linux-sunxi

Dne sobota, 02. julij 2022 ob 21:01:34 CEST je Samuel Holland napisal(a):
> The sunxi legacy clocks were never compatible with any 64-bit SoC,
> so there is no point in building them as part of a 64-bit ARM kernel.
> They make even less sense being built in to a 64-bit RISC-V kernel.
> 
> Signed-off-by: Samuel Holland <samuel@sholland.org>

Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] clk: sunxi: Do not select the PRCM MFD
  2022-07-02 19:01 ` [PATCH 2/2] clk: sunxi: Do not select the PRCM MFD Samuel Holland
@ 2022-07-02 19:10   ` Jernej Škrabec
  0 siblings, 0 replies; 5+ messages in thread
From: Jernej Škrabec @ 2022-07-02 19:10 UTC (permalink / raw)
  To: Chen-Yu Tsai, Emilio López, Stephen Boyd, Michael Turquette,
	Samuel Holland
  Cc: Samuel Holland, linux-arm-kernel, linux-clk, linux-kernel,
	linux-sunxi

Dne sobota, 02. julij 2022 ob 21:01:35 CEST je Samuel Holland napisal(a):
> The PRCM MFD driver is already selected by the two platforms where it is
> actually used (MACH_SUN6I and MACH_SUN8I). Selecting it here builds it
> unnecessarily on the rest of the Allwinner platforms.
> 
> Signed-off-by: Samuel Holland <samuel@sholland.org>

Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Re: [PATCH 1/2] clk: sunxi: Limit legacy clocks to 32-bit ARM
  2022-07-02 19:09 ` [PATCH 1/2] clk: sunxi: Limit legacy clocks to 32-bit ARM Jernej Škrabec
@ 2022-07-04 20:05   ` Jernej Škrabec
  0 siblings, 0 replies; 5+ messages in thread
From: Jernej Škrabec @ 2022-07-04 20:05 UTC (permalink / raw)
  To: Chen-Yu Tsai, Emilio López, Stephen Boyd, Michael Turquette,
	Samuel Holland
  Cc: Samuel Holland, linux-arm-kernel, linux-clk, linux-kernel,
	linux-sunxi

Dne sobota, 02. julij 2022 ob 21:09:18 CEST je Jernej Škrabec napisal(a):
> Dne sobota, 02. julij 2022 ob 21:01:34 CEST je Samuel Holland napisal(a):
> > The sunxi legacy clocks were never compatible with any 64-bit SoC,
> > so there is no point in building them as part of a 64-bit ARM kernel.
> > They make even less sense being built in to a 64-bit RISC-V kernel.
> > 
> > Signed-off-by: Samuel Holland <samuel@sholland.org>
> 
> Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Applied both, thanks!
 
Best regards,
Jernej



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-07-04 20:06 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-02 19:01 [PATCH 1/2] clk: sunxi: Limit legacy clocks to 32-bit ARM Samuel Holland
2022-07-02 19:01 ` [PATCH 2/2] clk: sunxi: Do not select the PRCM MFD Samuel Holland
2022-07-02 19:10   ` Jernej Škrabec
2022-07-02 19:09 ` [PATCH 1/2] clk: sunxi: Limit legacy clocks to 32-bit ARM Jernej Škrabec
2022-07-04 20:05   ` Jernej Škrabec

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox