From: Patrick McHardy <kaber@trash.net>
To: Andries Brouwer <Andries.Brouwer@cwi.nl>
Cc: torvalds@osdl.org, akpm@osdl.org, coreteam@netfilter.org,
linux-kernel@vger.kernel.org
Subject: Re: [netfilter-core] [PATCH] no __initdata in netfilter?
Date: Sun, 14 Nov 2004 08:56:29 +0100 [thread overview]
Message-ID: <41970FAD.6010501@trash.net> (raw)
In-Reply-To: <20041114013724.GA21219@apps.cwi.nl>
Andries Brouwer wrote:
>Stuff marked initdata that is referenced in non-init context.
>
Where ? The initial tables are replaced by ipt_register_table.
Regards
Patrick
>diff -uprN -X /linux/dontdiff a/net/ipv4/netfilter/ip_nat_rule.c b/net/ipv4/netfilter/ip_nat_rule.c
>--- a/net/ipv4/netfilter/ip_nat_rule.c 2004-10-30 21:44:11.000000000 +0200
>+++ b/net/ipv4/netfilter/ip_nat_rule.c 2004-11-13 22:40:51.000000000 +0100
>@@ -59,8 +59,8 @@ static struct
> struct ipt_replace repl;
> struct ipt_standard entries[3];
> struct ipt_error term;
>-} nat_initial_table __initdata
>-= { { "nat", NAT_VALID_HOOKS, 4,
>+} nat_initial_table = {
>+ { "nat", NAT_VALID_HOOKS, 4,
> sizeof(struct ipt_standard) * 3 + sizeof(struct ipt_error),
> { [NF_IP_PRE_ROUTING] = 0,
> [NF_IP_POST_ROUTING] = sizeof(struct ipt_standard),
>diff -uprN -X /linux/dontdiff a/net/ipv4/netfilter/iptable_filter.c b/net/ipv4/netfilter/iptable_filter.c
>--- a/net/ipv4/netfilter/iptable_filter.c 2004-10-30 21:44:11.000000000 +0200
>+++ b/net/ipv4/netfilter/iptable_filter.c 2004-11-13 22:40:51.000000000 +0100
>@@ -44,8 +44,8 @@ static struct
> struct ipt_replace repl;
> struct ipt_standard entries[3];
> struct ipt_error term;
>-} initial_table __initdata
>-= { { "filter", FILTER_VALID_HOOKS, 4,
>+} initial_table = {
>+ { "filter", FILTER_VALID_HOOKS, 4,
> sizeof(struct ipt_standard) * 3 + sizeof(struct ipt_error),
> { [NF_IP_LOCAL_IN] = 0,
> [NF_IP_FORWARD] = sizeof(struct ipt_standard),
>
>
>
next prev parent reply other threads:[~2004-11-14 7:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-14 1:37 [PATCH] no __initdata in netfilter? Andries Brouwer
2004-11-14 7:56 ` Patrick McHardy [this message]
2004-11-14 11:26 ` [netfilter-core] " Andries Brouwer
2004-12-14 13:00 ` Harald Welte
2004-12-14 15:52 ` Linus Torvalds
2004-12-14 18:39 ` Andries Brouwer
2004-12-14 18:51 ` Harald Welte
2004-12-15 4:21 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41970FAD.6010501@trash.net \
--to=kaber@trash.net \
--cc=Andries.Brouwer@cwi.nl \
--cc=akpm@osdl.org \
--cc=coreteam@netfilter.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox